Skip to content

[v4.1.x] Additional fixes for 4.1.6#927

Merged
kblaschke merged 21 commits intoprojectM-visualizer:v4.1.xfrom
kblaschke:v4.1.x-cherry-picked-fixes-for-4.1.6
Nov 28, 2025
Merged

[v4.1.x] Additional fixes for 4.1.6#927
kblaschke merged 21 commits intoprojectM-visualizer:v4.1.xfrom
kblaschke:v4.1.x-cherry-picked-fixes-for-4.1.6

Conversation

@kblaschke
Copy link
Member

@kblaschke kblaschke commented Nov 10, 2025 •
edited
Loading

Cherry-picked Boost-/build-related fixes and workflow improvements from master. Also bumped the projectm-eval submodule to v1.0.5. The version was already set to 4.1.6 for immediate release after merge.

  • Fixed an issue with blur textures, as projectM previously used the warped image, and not the previous frame plus motion vectors as it should be. This may positively affect quite a few presets, so I've included the fix in this release.
  • Fixed an issue with the decay value being clamped to [0, 0.9375] instead of [0, 1].
  • Updated projecmt-eval submodule to 1.0.5
  • Updated vcpkg baseline commit to include projectm-eval 1.0.5
  • Added more workflows to check different build configurations
  • Fixed two operator issues in waveform implementations
  • Default waveforms were all drawn upside-down. Fixed by using a y-flipped tranformation matrix.
  • Set vertex_point_size uniform in untextured draws to the proper value instead of leaving it undefined.

@kblaschke
Add missing <chrono> include in Playlist.cpp
e9572b3
@kblaschke
Use Boost's own CMake configuration file instead of CMake's module
cc8a3f6 
Otherwise, breaks builds with newer Boost versions. Also set policy CMP0167 to NEW and forcing CMake to use the Config package and not the built-in module. Will now require Boost 1.70, but this should be available everywhere.
@kblaschke kblaschke added this to the 4.1.6 milestone Nov 10, 2025
@kblaschke kblaschke self-assigned this Nov 10, 2025
@kblaschke kblaschke added the bug The issue is (potentially) a bug. label Nov 10, 2025
@kblaschke kblaschke added important Important bugs or features which should be fixed/implemented ASAP. cmake The issue is about the CMake build code or an issue with CMake itself in regards to projectM. labels Nov 10, 2025
@kblaschke kblaschke force-pushed the v4.1.x-cherry-picked-fixes-for-4.1.6 branch from 4866888 to 148d180 Compare November 10, 2025 11:25
@yoyofr @kblaschke
Use previous frame's image (plus motion vectors) in blur textures
e3f19db 
Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
@kblaschke kblaschke force-pushed the v4.1.x-cherry-picked-fixes-for-4.1.6 branch from 148d180 to e36ad01 Compare November 10, 2025 11:27
mbaetgen-wup
mbaetgen-wup reviewed Nov 11, 2025
View reviewed changes
@kblaschke kblaschke force-pushed the v4.1.x-cherry-picked-fixes-for-4.1.6 branch from e36ad01 to 0c71b10 Compare November 11, 2025 08:40
@kblaschke kblaschke changed the title [v4.1.x] Cherry-picked fixes for 4.1.6 [v4.1.x] Additional fixes for 4.1.6 Nov 11, 2025
@kblaschke kblaschke force-pushed the v4.1.x-cherry-picked-fixes-for-4.1.6 branch from 0c71b10 to d957272 Compare November 11, 2025 09:09
@kblaschke kblaschke linked an issue Nov 11, 2025 that may be closed by this pull request
[DEV BUG] Incorrect rendering of certain pre-2.0 presets possibly due to default warp shader #930
Closed
2 tasks
@kblaschke kblaschke moved this to In Review in libprojectM Release 4.1 Nov 11, 2025
yoyofr and others added 3 commits November 12, 2025 10:01
@yoyofr @kblaschke
Set vertex_point_size uniform for all uses of the untextured vertex s…
7e5f84b 
…hader

Only custom waves set the point size to 2, default waveforms still render the 2x2 pattern when using dots. Other draw calls aren't affected as they only draw lines/triangles, but it's good practice to not leave the uniform in an undefined state.

Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
@yoyofr @kblaschke
Fix some default waveform rendering bugs
82b71e2 
All waves were rendered upside-down, breaking presets requiring the wave to be at the top or bottom due to warp movement. Using the flipped transformation matrix for drawing will take care of this globally.

Also fixed two small mistakes regarding operators.

Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
@kblaschke
Remove decay value fix for 16-bit GPUs, as it capped decay to 0.9375.
406e5c9
@kblaschke kblaschke force-pushed the v4.1.x-cherry-picked-fixes-for-4.1.6 branch from d957272 to 60b60dc Compare November 12, 2025 09:01
@yoyofr @kblaschke
fixed an issue with sep attribute mngt / per pixel
f8fe003 
Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
@yoyofr @kblaschke
Add additional row-access functions for matrices in HLSL transpiler
961ed47 
Fixes "martin - mayday (shifters escape retouched).milk" and probably some others.

Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
@yoyofr @kblaschke
Remove warp texel offset, introduced drift in warp shader.
082f3b7 
Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
@yoyofr @kblaschke
Add missing "fwidth" intrinsic in HLSL transpiler
ae4246c 
Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
@yoyofr @kblaschke
Fix a constant's type in float acos(float) overload in HLSL transpiler
fdd9428 
Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
@yoyofr @kblaschke
Place shader "PS" function into its own line and wrap arguments for r…
0ac5c24 
…eadability.

Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
@yoyofr @kblaschke
Fix wrong type used in PCM smoothing in custom waves.
f55d4a9 
Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
@kblaschke kblaschke force-pushed the v4.1.x-cherry-picked-fixes-for-4.1.6 branch from 60b60dc to 68d9832 Compare November 19, 2025 12:04
@kblaschke
Copy link
Member Author

kblaschke commented Nov 19, 2025

Added a bunch more fixes from @yoyofr

revmischa
revmischa approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@revmischa revmischa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@yoyofr @kblaschke
Apply possible HLSL compiler optimization for pow() function with lit…
19e945c 
…eral 1 as exponent

Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
@kblaschke kblaschke force-pushed the v4.1.x-cherry-picked-fixes-for-4.1.6 branch from 8ce4ab8 to b56c3e8 Compare November 20, 2025 09:57
@kblaschke
Keep references to textures and samplers in descriptors
7b299de 
Previously, if the TextureManager was recreated, e.g. when changing the texture paths, all loaded textures were deleted, even if currently in use by a preset. Storing textures and samplers as shared pointers instead of weak pointers will make sure the objects are kept alive until the preset is unloaded.

Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
@kblaschke
Add workflow configurations to test boost-filesystem and more platfor…
c700dba 
…ms/archs
@kblaschke
Bump projectm-eval submodule version to 1.0.5
66b0b47
@kblaschke
Update vcpkg repo baseline commit to include projectm-eval 1.0.5
3371d86
@kblaschke
Bump libprojectM version to 4.1.6
3158ee6
@kblaschke kblaschke force-pushed the v4.1.x-cherry-picked-fixes-for-4.1.6 branch from b56c3e8 to 3158ee6 Compare November 24, 2025 09:59
@kblaschke kblaschke added the enhancement The feature is considered an enhancement. label Nov 27, 2025
@kblaschke kblaschke merged commit 3158ee6 into projectM-visualizer:v4.1.x Nov 28, 2025
37 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in libprojectM Release 4.1 Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@revmischa revmischa revmischa approved these changes

@dpw13 dpw13 Awaiting requested review from dpw13

@blaquewithaq blaquewithaq Awaiting requested review from blaquewithaq

+1 more reviewer

@mbaetgen-wup mbaetgen-wup mbaetgen-wup approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kblaschke kblaschke

Labels

bug The issue is (potentially) a bug. cmake The issue is about the CMake build code or an issue with CMake itself in regards to projectM. enhancement The feature is considered an enhancement. important Important bugs or features which should be fixed/implemented ASAP.

Projects

libprojectM Release 4.1
Status: Done

Milestone

4.1.6

Development

Successfully merging this pull request may close these issues.

[DEV BUG] Incorrect rendering of certain pre-2.0 presets possibly due to default warp shader

4 participants

@kblaschke @revmischa @mbaetgen-wup @yoyofr