Skip to content

Conversation

@RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Jul 10, 2024

@RamanaReddy0M RamanaReddy0M self-assigned this Jul 10, 2024
@RamanaReddy0M RamanaReddy0M linked an issue Jul 10, 2024 that may be closed by this pull request
@RamanaReddy0M
Copy link
Contributor Author

✗ go run . -u 'http://google.co.uk:80' -j -silent | jq -c '{input,host}'
{"input":"http://google.co.uk:80","host":"172.217.27.195"}

@RamanaReddy0M
Copy link
Contributor Author

depends on: projectdiscovery/fastdialer#314

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the origin pr is merged now we should use commit from main branch to avoid invalid revision issue

If commit of a deleted brach is referenced , after it is purged from go module proxy cache , it will throw invalid revision when installing using go install , i.e why we can use release tag or ref commit from branch that will not be deleted ( like main or master)

@tarunKoyalwar tarunKoyalwar requested a review from ehsandeep July 11, 2024 21:00
@ehsandeep
Copy link
Member

@RamanaReddy0M @tarunKoyalwar this is unrelated to this PR, but do we know why windows test are failing?

@RamanaReddy0M
Copy link
Contributor Author

RamanaReddy0M commented Jul 12, 2024

Screenshot 2024-07-12 at 10 03 15 AM It seems like only on windows some how `\n` is getting added to the results. I will look into this.

@ehsandeep ehsandeep merged commit 6d3ef37 into dev Jul 12, 2024
@ehsandeep ehsandeep deleted the issue-1815-host-property-empty branch July 12, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.host Property Occasionally Missing From Version 1.6.2 Onwards 2

4 participants