Skip to content

Dismiss alert lead to take screenshot #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mzack9999 merged 6 commits into from
Sep 12, 2025
Merged

Dismiss alert lead to take screenshot #2219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d9a2775
Dismiss alert lead to take screenshot
Serizao Jul 23, 2025
2db3aba
Merge branch 'dev' into patch-1
Serizao Jul 23, 2025
d6e95e1
Update headless.go
Serizao Jul 23, 2025
04fd376
Merge branch 'dev' into patch-1
Serizao Jul 30, 2025
84a54b9
Merge branch 'dev' into pr/2219
Mzack9999 Sep 12, 2025
ad83070
better handling
Mzack9999 Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions runner/headless.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,14 @@ func (b *Browser) ScreenshotWithBody(url string, timeout time.Duration, idle tim
if err != nil {
return nil, "", err
}

go page.EachEvent(func(e *proto.PageJavascriptDialogOpening) {
_ = proto.PageHandleJavaScriptDialog{
Accept: true,
PromptText: "",
}.Call(page)
})()

for _, header := range headers {
headerParts := strings.SplitN(header, ":", 2)
if len(headerParts) != 2 {
Expand Down
1 change: 0 additions & 1 deletion runner/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,6 @@ func makePrintCallback() func(stats clistats.StatisticsClient) interface{} {
builder.WriteString(clistats.String(totalHosts))
builder.WriteRune(' ')
builder.WriteRune('(')
//nolint:gomnd // this is not a magic number
builder.WriteString(clistats.String(uint64(float64(hosts) / float64(totalHosts.(int)) * 100.0)))
builder.WriteRune('%')
builder.WriteRune(')')
Expand Down
Loading