Skip to content

Conversation

@DFwJZ
Copy link
Contributor

@DFwJZ DFwJZ commented Oct 10, 2025

The actual code requires go >= 1.24.0 but the documentation still mentions 1.21.

Updated to reflect the correct requirement.

image

Summary by CodeRabbit

  • Documentation
    • Updated installation instructions to reflect a new minimum Go version requirement of 1.24.0 or later.
    • Clarifies version compatibility to reduce setup issues and align guidance with current support expectations.
    • Improves onboarding by ensuring users install with a compatible toolchain.
    • No functional changes to features; this is a documentation-only update to keep instructions accurate and current.

…allation

The actual code requires go >= 1.24.0 but the documentation still mentions 1.21. Updated to reflect the correct requirement.
@coderabbitai
Copy link

coderabbitai bot commented Oct 10, 2025

Walkthrough

Raised the minimum Go version in README installation instructions for httpx from 1.21 to 1.24.0.

Changes

Cohort / File(s) Summary
Documentation
README.md
Updated stated minimum Go version for httpx installation from 1.21 to 1.24.0; command unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nibbled the notes with a tidy hop,
bumped Go to 1.24—no need to stop.
The command stays crisp, the path still clear,
just fresher carrots for builds this year.
Thump-thump! Docs aligned, onward we cheer. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title accurately summarizes the primary change by stating that the Go version requirement is being updated from 1.21 to 1.24 for httpx v1.7.1, directly reflecting the documentation update described in the PR. It is clear, specific, and avoids vague or extraneous language. A reviewer can immediately grasp the core purpose of the pull request without needing additional context.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7dfd091 and 4346dfe.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🔇 Additional comments (1)
README.md (1)

65-65: Docs align with the Go 1.24 requirement.

The updated minimum version matches the stated tool requirement. Thanks for keeping the docs accurate.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dogancanbakir dogancanbakir merged commit 25a059b into projectdiscovery:dev Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants