Don't drop to newline when serializing patterns starting with special chars #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pike
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
LGTM, just two nits that would make this code safe in cases where you programmatically create weird patterns. As I mentioned on the js one, the first is safe. Not sure about the empty text one.
I'd rely on whatever IDEA says in tooltips ;-)
Nice that the check is in one loop, instead of looping twice. That's a nit I dropped nagging about on the js impl ;-)
fluent.syntax/src/main/kotlin/org/projectfluent/syntax/serializer/Serializer.kt
Outdated
Show resolved
Hide resolved
fluent.syntax/src/main/kotlin/org/projectfluent/syntax/serializer/Serializer.kt
Outdated
Show resolved
Hide resolved
stasm
force-pushed
the
fix-special-chars-start-inline
branch
from
eeae1b7 to
bee1715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A port of projectfluent/fluent.js#513.