0.5 comments #39
0.5 comments #39
Conversation
src/syntax/parser.rs
Outdated
| fn get_comment<I>(ps: &mut ParserStream<I>) -> Result<ast::Comment> | ||
| #[derive(PartialEq)] | ||
| enum CommentLevel { | ||
| Comment, |
There was a problem hiding this comment.
You should be able to use the Comment = 0, syntax in this enum to avoid the match a few lines below. I think you'll need to add Copy to the enum though to make it work.
src/syntax/parser.rs
Outdated
| @@ -152,6 +153,13 @@ where | |||
| { | |||
| let id = get_identifier(ps, true)?; | |||
|
|
|||
| if comment.is_some() { | |||
There was a problem hiding this comment.
Is this outer is_some needed here? It looks like the if let below it serves the same function (and more).
zbraniecki
force-pushed
the
0.5-comments
branch
2 times, most recently
from
0f0da93 to
d749049
Compare
src/syntax/parser.rs.orig
Outdated
| @@ -0,0 +1,721 @@ | |||
| pub use super::errors::ParserError; | |||
src/syntax/parser.rs
Outdated
| @@ -152,6 +143,11 @@ where | |||
| { | |||
| let id = get_private_identifier(ps)?; | |||
|
|
|||
| if let Some(ast::Comment::Comment { .. }) = comment { | |||
| } else if comment.is_some() { | |||
There was a problem hiding this comment.
I don't understand this code. It looks like both if let and else if test if comment is a Some?
There was a problem hiding this comment.
heh, yeah, it's awkward. What I'm trying to test is if the variant of the Comment passed to get_message is actually ast::Comment::Comment and not GroupComment or ResourceComment.
If it's not, then I'm verifying that it's None.
Any ideas how to write it better? :)
There was a problem hiding this comment.
Ahh, I see now, thanks. I might have wrongly suggested to use if let here then. Maybe a match like this?
match comment {
Some(ast::Comment::GroupComment { .. }) => error!(),
Some(ast::Comment::ResourceComment { .. }) => error!(),
_ => ()
}In the future, rust-lang/rfcs#935 will help.
zbraniecki
force-pushed
the
0.5-comments
branch
from
d749049 to
3b848c1
Compare
zbraniecki
force-pushed
the
0.5-comments
branch
from
3b848c1 to
1d07e93
Compare
Built on top of the private msg PR. Need to add tests, but hopefully a good start :)