Allow whitespace before CallArguments (fixes #421) #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbraniecki
approved these changes
Aug 8, 2019
| @@ -685,13 +687,15 @@ class FluentParser { | |||
|
|
|||
| if (ps.isIdentifierStart()) { | |||
| const id = this.getIdentifier(ps); | |||
| ps.peekBlank(); | |||
There was a problem hiding this comment.
alternatively, you could store the ptr, skipBlank and then only take currentChar === "." if stored_ptr == ptr.
There was a problem hiding this comment.
That's like re-implementing peek, that doesn't smell right. If I'd want to change this, I'd look for ways to structure the code so that I could just eat the whitespace, because there's no grammar structure that doesn't allow it.
But then I didn't want to invest my brain in that, too.
This is picking up the tests for projectfluent/fluent#281, and adjusts the parser to pass those tests.
This was referenced Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is picking up the tests for projectfluent/fluent#281,
and adjusts the parser to pass those tests.
I'm not happy with the peek, but this is what makes the tests pass.