Update TypeScript and typedoc #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For projectfluent#524, I'll want new TypeScript features, so updating TypeScript. The new TypeScript requires a new typedoc. Which removed the setup we used to generated the docs (--mode=file) because it was duh. Now the docs are actually for the exposed symbols of the module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #524, I'll want new TypeScript features, so updating TypeScript.
The new TypeScript requires a new typedoc. Which removed the setup we used to generated the docs (--mode=file) because it was duh.
Now the docs are actually for the exposed symbols of the module.
I've staged the generated documentation for this on https://pike.github.io/fluent.js/. The index.html is fake. The actual changes are in Pike@1847d1b, but that's big.
I reviewed each module, and I think the changes are good. The biggest difference was in
langneg, wherefilterMatchesdropped from the docs. I wasn't comfortable about that, so I added it to the module exports.TechDebt is beautiful.