Variable casting and Temporal support#635
Closed
rkh wants to merge 2 commits intoprojectfluent:mainfrom
Closed
Conversation
This was referenced Feb 13, 2025
rkh
commented
Feb 13, 2025
| "license": "Apache-2.0", | ||
| "contributors": [ | ||
| { | ||
| "name": "Konstantin Haase", |
Contributor
Author
There was a problem hiding this comment.
Put myself in here. You can take me out, though. I'm happy to "gift" this little library to Mozilla.
Contributor
Author
|
I am happy to work on the remaining Temporal classes, especially Duration. We are working on a production app (pre-alpha atm) where we use a Temporal polyfill and Fluent, and we're expecting to use almost all Temporal classes eventually, so I'm also happy to keep an eye on any bugs etc that pop up in the future. |
Merged
Member
|
I think this level of generalisation is a bit too much, and we should just add Temporal support as in #636. If there is a real need for something like this later on, it would be best to package the functionality within FluentNumber, FluentDateTime, and related classes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #634
Variable casting
Went for a slightly different API than in the issue.
Temporal support
I've put this in a separate package for now, as Temporal is still considered experimental.
It also currently only supports
InstantandZonedDateTime.Best illustration is probably bundle_test.js.