Change Annotation to { code, args, message, span } #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbraniecki
approved these changes
Mar 31, 2017
Annotations now have unique codes: E0000 for errors, W0000 for warnings and H0000 for hints. Args is an array of strings with additional arguments used for building the message of the Annotation. Annotations also now have a span, similar to Entries. If an annotation is only related to a single position in the file, the Span's start and end field should be equal.
stasm
changed the title
|
I made a change to the PR and added another field to This is modeled after https://docs.python.org/3/library/exceptions.html#BaseException.args and can be used to verify that annotations include extra information about parsing errors. It also opens up a way to localize annotations in CAT tools. |
zbraniecki
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotations will now have unique codes: E0000 for errors, W0000 for warnings
and H0000 for hints. They also now have a span, similar to Entries. If an
annotation is only related to a single position in the file, the Span's start
and end field should be equal.