-
Notifications
You must be signed in to change notification settings - Fork 14
Use the -O flag for improved performance in error handling #31 #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use the -O flag for improved performance in error handling #31 #141
Conversation
Replacing common error code with more optimize code using assert / __debug__ for production ready build along with maintaining error handling capabilities for development
for more information, see https://pre-commit.ci
fixing optimization code
for more information, see https://pre-commit.ci
fixed build test
…ing-projectmesa#31' of https://github.com/reyan-singh/mesa-frames into Use-the--O-flag-for-improved-performance-in-error-handling-projectmesa#31
fixed build code
updating agent to fix build
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage ? 91.68%
=======================================
Files ? 11
Lines ? 1684
Branches ? 0
=======================================
Hits ? 1544
Misses ? 140
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use if __debug__
code blocks so when we raise an error to the user, it's actually informative
Updated assert code along with __debug__ to make code informtive while in debug mode but optimized when build with -O option
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
for more information, see https://pre-commit.ci
@adamamer20 added debug code block and checks are passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of assertions, raise informative errors to the user
modifying assert code with raise... to raise informative errors to the user
done, used raise instead of assert |
Merge from main and remove the pandas file to be able to merge this to main |
for more information, see https://pre-commit.ci
@adamamer20 I have merged the changes |
Replacing common error code with more optimize code using assert / debug for production ready build along with maintaining error handling capabilities for development