Added support for bgp session state as value #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluecmd
reviewed
Jul 20, 2023
|
LGTM except for the somewhat weird go.mod/go.sum changes |
Resolved by rebasing |
|
@33Fraise33 Tests need to be updated as well |
|
Hi @bluecmd I am just guessing here as I have no experience with this, tests seem to run on my system (if I check the ci command: |
bluecmd
approved these changes
Jul 25, 2023
|
Thanks! |
Jurka007
pushed a commit
to Jurka007/fortigate_exporter
that referenced
this pull request
Mar 7, 2025
* fix(BGP Info): Added support for bgp session state as value next to label * test(bgp): Updated tests to account for new value * test(bgp): Also change metric description in tests --------- Co-authored-by: Gianni Stubbe <[email protected]> Signed-off-by: jiri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #195