Skip to content

Dashboard linting improvements for mixin #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rgeyer
Copy link
Contributor

@rgeyer rgeyer commented May 25, 2022

Some changes to accommodate the dashboard linter, caught several minor (or moderate?) issues.

  • Most (all?) queries were not using the $job matcher
  • The template vars were set with default selected values, which weren't ideal
  • The instance template var was not filtering to instances belonging to the selected job(s)
  • Reorganized template vars from broadest to most specific

@Whyeasy
Copy link

Whyeasy commented Jan 18, 2023

Could this PR please be reviewed? I'm currently unable to use this mixin.

Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not super familiar with the grafana dashboard JSON, but it LGTM. Thanks!

@sysadmind sysadmind merged commit d23b0b2 into prometheus-community:master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants