alerts: fix duplicate series in InfoInhibitor alert #2786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonnet/kube-prometheus/components/mixin/alerts/general.libsonnet
Outdated
Show resolved
Hide resolved
Author
|
@simonpasquier pushed the suggestion |
varundeepsaini
force-pushed
the
fix/infoinhibitor-duplicate-series
branch
from
1660d5f to
a5be32e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the InfoInhibitor alert failing to evaluate with a "duplicate series" error in Prometheus.
When multiple info-level alerts fire in the same namespace, the current expression can produce multiple series with the same labelset after the
unless on(namespace)operation, causing Prometheus to fail evaluation.The fix uses
count by (namespace)to aggregate alerts, ensuring each side of theunlessoperator produces exactly one series per namespace.Fixes #2751
Related: prometheus-community/helm-charts#5873
Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry