Skip to content

Lift moratorium on AlertManager receivers with long-term maintenance plan#2561

Merged
roidelapluie merged 2 commits into
prometheus:masterfrom
maxbrodin:master
May 4, 2021
Merged

Lift moratorium on AlertManager receivers with long-term maintenance plan#2561
roidelapluie merged 2 commits into
prometheus:masterfrom
maxbrodin:master

Conversation

@maxbrodin

Copy link
Copy Markdown
Contributor

This documentation change is intended to lift moratorium on new AlertManager receivers with long-term maintenance plan.

Signed-off-by: Max Brodin <mbrodin@amazon.com>
@roidelapluie

Copy link
Copy Markdown
Member

We probably want to reuse the phrasing in prometheus:

Note: As part of lifting the past moratorium on new SD implementations it was agreed that, in addition to the existing requirements, new service discovery implementations will be required to have a committed maintainer with push access (i.e., on -team).

Signed-off-by: Max Brodin <mbrodin@amazon.com>
@maxbrodin

Copy link
Copy Markdown
Contributor Author

Right. Added a note:

Note: As part of lifting the past moratorium on new receivers it was agreed that, in addition to the existing requirements, new notification integrations will be required to have a committed maintainer with push access.

@roidelapluie roidelapluie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will merge this in a few days to make sure we have lazy consensus.

@gotjosh gotjosh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roidelapluie roidelapluie merged commit 1f3796c into prometheus:master May 4, 2021
paulfantom added a commit to paulfantom/alertmanager that referenced this pull request Jul 23, 2021
v0.22.2

* tag 'v0.22.2': (181 commits)
  Release 0.22.2
  Include pending silences for future muting decisions
  Release 0.22.1
  Default the isEqual flag to true in alertmanager
  Add test to expose issue prometheus#2426
  Release alertmanager 0.22
  Relase 0.22.0-rc.2
  API: Only pass cluster peer if empty
  fixed small typo
  Release 0.22.0-rc.1
  Fix panic when HA is disabled
  Update matcher examples
  Add prometheus#2276 to release notes
  Release 0.22.0-rc.0
  Lift moratorium on AlertManager receivers with long-term maintenance plan (prometheus#2561)
  Add OAuth 2.0 Config (prometheus#2560)
  Add missing EOL
  Fix flapping acceptance test
  Unlock at specific points instead of deferring
  Dispatch: Make sure mutex gets unlocked on call to Stop
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants