WIP: Add ability to test alert inhibition #4822
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `config inhibition test` that given the configuration file, the firing alerts, verify that a set of labels are/are not inhibited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no way to test/assert that an inhibition rule is working as intended. I would like to add a tool similar to the
promtool test. The attached MR starts with adding tests for inhibitions and that is useful as such.How far should we take this? We could add assertions for alert grouping. Given these firing alerts, assert that these aggregator groups exist. Given the ability to mute alerts based on time. Would we want to introduce timeouts as well?