Skip to content

Build break after updating #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jimsnab opened this issue Feb 23, 2024 · 6 comments · Fixed by #1448
Closed

Build break after updating #1446

jimsnab opened this issue Feb 23, 2024 · 6 comments · Fixed by #1448

Comments

@jimsnab
Copy link

jimsnab commented Feb 23, 2024 •
edited
Loading 

./../../go/pkg/mod/github.com/prometheus/[email protected]/prometheus/push/push.go:112:22: undefined: expfmt.FmtProtoDelim

Seems to be because of

github.com/prometheus/common v0.45.0 => v0.48.0

My project has github.com/snowflakedb/snowflake v1.8.0 which pulls in so many (unwanted) dependencies, including AWS SDK. It seems this break comes in by picking up the AWS sdk v1.25.1.

go: upgraded github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.6.0 => v1.6.1
go: upgraded github.com/aws/aws-sdk-go-v2/credentials v1.17.0 => v1.17.3
go: upgraded github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.16.2 => v1.16.5
go: upgraded github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.0 => v1.3.1
go: upgraded github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.0 => v2.6.1
go: upgraded github.com/aws/aws-sdk-go-v2/internal/v4a v1.3.0 => v1.3.1
go: upgraded github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.11.0 => v1.11.1
go: upgraded github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.3.0 => v1.3.1
go: upgraded github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.11.0 => v1.11.1
go: upgraded github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.17.0 => v1.17.1
go: upgraded github.com/aws/aws-sdk-go-v2/service/s3 v1.50.1 => v1.51.0
go: upgraded github.com/aws/smithy-go v1.20.0 => v1.20.1
go: upgraded github.com/klauspost/compress v1.17.6 => v1.17.7
go: upgraded github.com/klauspost/cpuid/v2 v2.2.6 => v2.2.7
go: upgraded github.com/prometheus/client_model v0.5.0 => v0.6.0
go: upgraded github.com/prometheus/common v0.45.0 => v0.48.0
go: upgraded golang.org/x/exp v0.0.0-20240213143201-ec583247a57a => v0.0.0-20240222234643-814bf88cf225
go: upgraded google.golang.org/protobuf v1.31.0 => v1.32.0

Obviously swimming in all these versions is difficult to diagnose, so I'm not sure what's wrong.

Update: looks like the following change made FmtProtoDelim private.

prometheus/common@v0.47.0...v0.48.0
@jimsnab
Copy link
Author

jimsnab commented Feb 23, 2024

@ywwg is this break from your change? prometheus/common@05d7387

@poszu poszu mentioned this issue Feb 23, 2024
Closed
This was referenced Feb 23, 2024
Closed
Closed
@erdii
Copy link

erdii commented Feb 23, 2024 •
edited
Loading

The same happens when using the promlint package:

# github.com/prometheus/client_golang/prometheus/testutil/promlint
$HOME/go/pkg/mod/github.com/prometheus/[email protected]/prometheus/testutil/promlint/promlint.go:71:38: undefined: expfmt.FmtText
FAIL	package-operator.run/internal/metrics [build failed]
FAIL

Go version: go version go1.22.0 linux/amd64
Links to:

erdii added a commit to erdii/cardboard that referenced this issue Feb 23, 2024
@erdii
downgrading prometheus-common back because of [1]
9202c9a 
[1] prometheus/client_golang#1446
@erdii erdii mentioned this issue Feb 23, 2024
Merged
erdii added a commit to erdii/cardboard that referenced this issue Feb 23, 2024
@erdii
downgrading prometheus-common back because of [1]
4bda8e2 
[1] prometheus/client_golang#1446
erdii added a commit to package-operator/cardboard that referenced this issue Feb 23, 2024
@erdii
downgrading prometheus-common back because of [1] (#78)
44f2ae9 
[1] prometheus/client_golang#1446
erdii added a commit to eqrx/package-operator that referenced this issue Feb 23, 2024
@erdii
bump cardboard dependency to v0.0.2 to downgrade github.comprometheus…
ff877a4 
…/common because of [1]

[1] prometheus/client_golang#1446

Signed-off-by: Josh Gwosdz <[email protected]>
@ywwg ywwg mentioned this issue Feb 23, 2024
Merged
ywwg added a commit to ywwg/client_golang that referenced this issue Feb 23, 2024
@ywwg
deps: bump prometheus/common version
2696b90 
Fixes prometheus#1446

Signed-off-by: Owen Williams <[email protected]>
ywwg added a commit to ywwg/client_golang that referenced this issue Feb 23, 2024
@ywwg
deps: bump prometheus/common version
6d03920 
Fixes prometheus#1446

Signed-off-by: Owen Williams <[email protected]>
@hansmi hansmi mentioned this issue Feb 23, 2024
Closed
@nicolaasuni-vonage
Copy link

Ref.: prometheus/common#577

It looks like this change has to be tagged in order to solve the issue.

@nicolaasuni-vonage
Copy link

nicolaasuni-vonage commented Feb 27, 2024 •
edited
Loading

Would you please reopen this issue and keep it open until the problem is actually fixed?
Or the issue should be addressed only by prometheus/common prometheus/common#577 ?

@ArthurSens
Copy link
Member

There you go!

https://github.com/prometheus/client_golang/releases/tag/v1.19.0

@nicolaasuni-vonage
Copy link

Thank you.

erdii added a commit to package-operator/package-operator that referenced this issue Mar 4, 2024
@thetechnick @kostola @erdii
Use cardboard instead of mage (#795)
fe61903 
* Use cardboard instead of mage

* Add do shorthand for cardboard and use it in pipeline

* Do not force docker for pipeline integration tests

* Change commands, add docs

* Name Integration tests ci target correctly

* Remove obsolete release target

* Fix integration tests

* Fix do

* Import real cardboard, remove devkube and mage imports

* Fix int and unit tests

* Join github action jobs and also you int coverage reports

* in ci use caching of setup-go instead of an extra step

* Fixes from review with the josh

* Let CI check if lint changes files

* Add dev.Create target

* Remove cardboard release taret

* Use most recent cardboard

* Use filepath.Join everywhere in cmd/build

* Use go1.22

* Fix linter hit that occured on rebase

* Fix integration tests not working

* Increase wait timeout for pko bootstrapping to 5mins since CI is slow

* Split cardboard main.go file

* clean up sweep

Signed-off-by: Josh Gwosdz <[email protected]>

* more update

* cmd/build: clean up compilation flags

- add `-buildid=` on top of trimpath to get one step closer towards reproducible builds golang/go#16860
- don't panic! (and return the error instead)

Signed-off-by: Josh Gwosdz <[email protected]>

* cmd/build: make int tests run again

Signed-off-by: Josh Gwosdz <[email protected]>

* decouple objecttemplate test (which for some reason includes a test for the `environment` capabilities of PKO) from used kubernetes version by fetching the cluster version from the apiserver insteadad of hardcoding it

Signed-off-by: Josh Gwosdz <[email protected]>

* clean up sweep²

Signed-off-by: Josh Gwosdz <[email protected]>

* make ci:release work almost 100%

Signed-off-by: Josh Gwosdz <[email protected]>

* cmd/build: make arch configurable for binary image builds and use host arch for building integration test images

Signed-off-by: Josh Gwosdz <[email protected]>

* fix release dependency ordering

Signed-off-by: Josh Gwosdz <[email protected]>

* cmd/build: remove forgotten hardcoded amd64 from buildImage

Signed-off-by: Josh Gwosdz <[email protected]>

* update to cardboard release v0.0.1

* bump cardboard dependency to v0.0.2 to downgrade github.comprometheus/common because of [1]

[1] prometheus/client_golang#1446

Signed-off-by: Josh Gwosdz <[email protected]>

* cmd/build: move .cache into a const and run mkdir -p .cache/integration before running the integration tests

Signed-off-by: Josh Gwosdz <[email protected]>

* burrrrrrito

Signed-off-by: Josh Gwosdz <[email protected]>

---------

Signed-off-by: Josh Gwosdz <[email protected]>
Co-authored-by: Nico Schieder <[email protected]>
Co-authored-by: Alessandro Costa <[email protected]>
Co-authored-by: Josh Gwosdz <[email protected]>
pbabic-redhat pushed a commit to pbabic-redhat/package-operator that referenced this issue Mar 5, 2024
@thetechnick @kostola
@erdii @pbabic-redhat
Use cardboard instead of mage (package-operator#795)
d54d34e 
* Use cardboard instead of mage

* Add do shorthand for cardboard and use it in pipeline

* Do not force docker for pipeline integration tests

* Change commands, add docs

* Name Integration tests ci target correctly

* Remove obsolete release target

* Fix integration tests

* Fix do

* Import real cardboard, remove devkube and mage imports

* Fix int and unit tests

* Join github action jobs and also you int coverage reports

* in ci use caching of setup-go instead of an extra step

* Fixes from review with the josh

* Let CI check if lint changes files

* Add dev.Create target

* Remove cardboard release taret

* Use most recent cardboard

* Use filepath.Join everywhere in cmd/build

* Use go1.22

* Fix linter hit that occured on rebase

* Fix integration tests not working

* Increase wait timeout for pko bootstrapping to 5mins since CI is slow

* Split cardboard main.go file

* clean up sweep

Signed-off-by: Josh Gwosdz <[email protected]>

* more update

* cmd/build: clean up compilation flags

- add `-buildid=` on top of trimpath to get one step closer towards reproducible builds golang/go#16860
- don't panic! (and return the error instead)

Signed-off-by: Josh Gwosdz <[email protected]>

* cmd/build: make int tests run again

Signed-off-by: Josh Gwosdz <[email protected]>

* decouple objecttemplate test (which for some reason includes a test for the `environment` capabilities of PKO) from used kubernetes version by fetching the cluster version from the apiserver insteadad of hardcoding it

Signed-off-by: Josh Gwosdz <[email protected]>

* clean up sweep²

Signed-off-by: Josh Gwosdz <[email protected]>

* make ci:release work almost 100%

Signed-off-by: Josh Gwosdz <[email protected]>

* cmd/build: make arch configurable for binary image builds and use host arch for building integration test images

Signed-off-by: Josh Gwosdz <[email protected]>

* fix release dependency ordering

Signed-off-by: Josh Gwosdz <[email protected]>

* cmd/build: remove forgotten hardcoded amd64 from buildImage

Signed-off-by: Josh Gwosdz <[email protected]>

* update to cardboard release v0.0.1

* bump cardboard dependency to v0.0.2 to downgrade github.comprometheus/common because of [1]

[1] prometheus/client_golang#1446

Signed-off-by: Josh Gwosdz <[email protected]>

* cmd/build: move .cache into a const and run mkdir -p .cache/integration before running the integration tests

Signed-off-by: Josh Gwosdz <[email protected]>

* burrrrrrito

Signed-off-by: Josh Gwosdz <[email protected]>

---------

Signed-off-by: Josh Gwosdz <[email protected]>
Co-authored-by: Nico Schieder <[email protected]>
Co-authored-by: Alessandro Costa <[email protected]>
Co-authored-by: Josh Gwosdz <[email protected]>
@Reecepbcups Reecepbcups mentioned this issue Mar 26, 2024
Closed
12 tasks
jiping-s added a commit to relex/gotils that referenced this issue Apr 25, 2024
@jiping-s
feat: Upgrade prometheus libraries and bump go to 1.21
27805b5 
Upgrade is necessary because prometheus introduced incompatible changes
prometheus/client_golang#1446
@jiping-s jiping-s mentioned this issue Apr 25, 2024
Merged
jiping-s added a commit to relex/gotils that referenced this issue Apr 25, 2024
@jiping-s
feat: Upgrade prometheus libraries and bump go to 1.21 (#43)
ad2a7eb 
Upgrade is necessary because prometheus introduced incompatible changes
prometheus/client_golang#1446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: bump prometheus/common version ywwg/client_golang
deps: bump prometheus/common version
4 participants
@erdii @ArthurSens @jimsnab @nicolaasuni-vonage