-
Notifications
You must be signed in to change notification settings - Fork 1.2k
test(registry): Add goleak-based goroutine leak detection #1797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f02cb1
to
44b3d1e
Compare
Signed-off-by: hyunuk <[email protected]>
44b3d1e
to
2ac28a9
Compare
bwplotka
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM -- was there any historical leak that trigger this PR?
One thing to ensure -- does this upset client_golang importers in terms of extra dependency. I assume NO given we only import this in test, importers should not see it (in theory).
Thanks! |
juliusmh
pushed a commit
to juliusmh/client_golang
that referenced
this pull request
Jun 30, 2025
…#1797) Signed-off-by: hyunuk <[email protected]>
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
This was referenced Jul 21, 2025
Merged
1 task
This was referenced Aug 7, 2025
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test(registry): Add goleak-based goroutine leak detection test for Registry.Gather
This commit adds a new test case
TestGatherDoesNotLeakGoroutines
which verifies that repeated calls toRegistry.Gather()
do not leak goroutines.Gather()
is called 1000 timesgoleak.VerifyNone
ensures that no unexpected goroutines remainThis test serves as a future safeguard to detect goroutine leaks under heavy usage.