exp/api: Bubble up status code from writeResponse #1823
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saswata Mukherjee <[email protected]>
saswatamcode
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
bwplotka
approved these changes
Jun 25, 2025
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
This was referenced Jul 31, 2025
1 task
1 task
This was referenced Jul 21, 2025
Merged
1 task
This was referenced Aug 7, 2025
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bubble up the write response code instead of hard-coding it to 204. The write response struct by default uses 204, but many rw 1.0 implementations in the wild will be using 2xx. This allows it to be flexible.
cc: @bwplotka