Add documentation about TTL and GH issues #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
juliusv
reviewed
Oct 2, 2018
.github/ISSUE_TEMPLATE.md
Outdated
| ## Feature request | ||
| **Use case. Why is this important?** | ||
|
|
||
| *Nice to have' is not a good use case :)* |
Member
There was a problem hiding this comment.
There's a single quote / apostrophe after "have" that doesn't have a corresponding opening quote?
Member
Author
There was a problem hiding this comment.
Yeah, copy&paste from the prometheus/prometheus issue template. I fixed it there, too: prometheus/prometheus#4688
juliusv
reviewed
Oct 2, 2018
.github/ISSUE_TEMPLATE.md
Outdated
|
|
||
| * Pushgateway command line: | ||
|
|
||
| insert full command line |
Member
There was a problem hiding this comment.
This line has tab indentation, the others have spaces
juliusv
reviewed
Oct 2, 2018
.github/ISSUE_TEMPLATE.md
Outdated
|
|
||
| * Logs: | ||
| ``` | ||
| insert Puhsgateway logs relevant to the issue here |
Member
|
👍 besides nits |
- Add an issue template similar to other repos. - Add TTL for metrics as a non-goal. Signed-off-by: beorn7 <[email protected]>
Member
Author
|
Thanks for the usual thorough spelling check. :o) All fixed, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@juliusv inspired by yet another follow-up to closed #19
Signed-off-by: beorn7 [email protected]