Repository navigation
chore: PDD sync for #1005 - #1010
Closed
prompt-driven-github[bot] wants to merge 0 commit into
Closed
prompt-driven-github[bot] wants to merge 0 commit into
prompt-driven-github[bot] wants to merge 0 commit into
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Collaborator
Step 7/8: Review Loop Final ReportPR: #1010 SummaryMax review rounds reached: 5. Per-Reviewer Status
Findings
Fixer Rationale
Fixes Attempted
|
This was referenced May 14, 2026
4 tasks
Serhan-Asad
added a commit
that referenced
this pull request
May 16, 2026
Iteration 1 of claude+codex review loop on PR #1010 (issue #1005). - Re-expose read_fingerprint, calculate_sha256, git, subprocess at module level so tests in test_sync_code_main.py can patch them. - derive_basename_and_language: accept str|Path, return /-joined relative stem and lowercase language; return (None, None) for unknown extensions. - _check_include_deps_changed, is_code_changed, get_git_changed_files: call helpers via module-level names; align reason strings; new merge-base call sequence. - Resolve pddrc strength in single-file and repo modes so .pddrc context values flow through to update_prompt. - Refresh .pdd/meta/update_main_python.json hashes to match current files. - Add test_single_file_metadata_writes_current_fingerprint_on_success integration test (issue #1005 acceptance criterion). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Serhan-Asad
force-pushed
the
change/issue-1005
branch
from
May 16, 2026 02:11
1a95b8a to
9ec9313
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
update_main_python.promptso that single-file and regeneration runs ofpdd update <code>always finalize the.pdd/meta/<module>.jsonfingerprint via the sharedmetadata_syncAPI, and surface explicit stderr warnings whenever finalization fails.Closes #1005
Changes Made
Prompts Modified
pdd/prompts/update_main_python.prompt— Rewrote Requirement 11 (Metadata finalization):_run_single_file_metadata_sync(prompt_path, code_path, dry_run=dry_run)unconditionally on success (no longer gated bysync_metadata=True).failedreasons) MUST be written to stderr viaConsole(stderr=True)orclick.echo(..., err=True), naming the stage and reason.Falsecausesupdate_mainto raiseclick.exceptions.Exit(1)so callers (including the preflight auto-heal subprocess) see a non-zero return code. No silent stale-metadata path remains.dry_runis plumbed through the helper so dry-runs remain a no-op.sync_metadata=True(out of scope per Split Contract).Architecture
architecture.json— Encoding-only refresh from the prompt edit (em-dashes re-serialized as\u2014); no semantic change.Review Checklist
dry_runsemantics preservedNext Steps After Merge
pytest -vv tests/test_update_main.pyto verify the regression tests for the happy path and the finalization-failure surface..pdd/meta/<module>.jsonis written after a successful single-filepdd update <code>run.Created by pdd change workflow