Pylint check broken with Pylint >= 2.0.0

[volans-]

In pylint/collector.py#26 this expression is used:

msg_data = self._message_store.check_message_id(msg_id)

But since pylint-dev/pylint#2077 was merged and then released, that method has been refactored to a different name: get_message_definition(). Hence now Prospector fails the pylint check with (only last part of the stacktrace attached):

  File "venv/lib/python3.6/site-packages/prospector/tools/pylint/collector.py", line 26, in add_message
    msg_data = self._message_store.check_message_id(msg_id)
AttributeError: 'MessagesStore' object has no attribute 'check_message_id'

Related package versions:

prospector==1.0
pylint==2.0.1

[matthewdeanmartin]

I also started getting a bunch of errors (on travis but not mac), despite adding output-format: grouped. Then I started to get errors inside pylint. So I rolled pylint back to 1.9.2 & things build again.

  File "/home/travis/virtualenv/python3.6.3/bin/prospector", line 11, in <module>
    sys.exit(main())
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/prospector/run.py", line 174, in main
    prospector.print_messages()
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/prospector/run.py", line 132, in print_messages
    formatter = FORMATTERS[output_format](self.summary, self.messages, self.config.profile)
KeyError: None

[chocoelho]

@volans- It's resolved in develop branch, but we'll need to wait until landscapeio/pylint-common#10 is merged so pylint >= 2 support is properly resolved.

[chocoelho]

@matthewdeanmartin the fix for is related to: #262

[volans-]

@chocoelho thanks for the fix, tested and works as expected.