feat!: add Edition 2024 Support#2053
Closed
mkruskal-google wants to merge 13 commits into
Closed
Conversation
This will now work as long as all files sharing a package agree on file-level edition and options
…nresolved options for fromJSON, fix aggregate feature handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds basic edition 2024 support in preparation for our upcoming 32.0 release. This is not completely finalized yet, and this PR will likely be held off until closer to the release date.
Edition 2024 only adds 2 new global features, and two grammar changes:
default_symbol_visibilityto control the default behavior. These will allow you to hide symbols from other proto files, but have no effect on codegen. The default behavior in 2024 changes from EXPORT_ALL to EXPORT_TOP_LEVEL, where only top-level symbols are exported without an explicitexportmodifier.enforce_naming_stylefeature will enable style guide enforcement in protoc by default starting in edition 2024. This can be disabled by setting it to STYLE_LEGACY