Skip to content

Add bazel targets for standalone plugin binaries #23919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bufdev wants to merge 10 commits into from
Closed

Add bazel targets for standalone plugin binaries #23919

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
be73f7e
Add bazel targets for standalone plugin binaries
bufdev Oct 10, 2025
5209c52
Make the targets public
srikrsna-buf Oct 10, 2025
d3ee677
Merge pull request #1 from srikrsna-buf/standalone-plugins
bufdev Oct 10, 2025
57d62a3
Rename to `plugin_main.cc`
srikrsna-buf Oct 15, 2025
f1c3629
Merge pull request #2 from srikrsna-buf/standalone-plugins
bufdev Oct 16, 2025
c446374
Merge branch 'main' into standalone-plugins
bufdev Nov 12, 2025
306e1d5
Merge branch 'standalone-plugins' of https://github.com/bufdev/protob…
bufdev Nov 12, 2025
735e3fd
Merge branch 'main' into standalone-plugins
bufdev May 16, 2026
b3a5952
Fix
bufdev May 17, 2026
45d44f6
Hopefully fix
bufdev May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/google/protobuf/compiler/cpp/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ load("//build_defs:cpp_opts.bzl", "COPTS")

cc_binary(
name = "protoc-gen-cpp",
srcs = ["main.cc"],
visibility = ["//:__pkg__"],
srcs = ["plugin_main.cc"],
visibility = ["//visibility:public"],

@zhangskz zhangskz Oct 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mark these all as //visibility:private for now? While we may want to officially support and release standalone binaries for these plugins at some point in the future, we would likely need to add corresponding supporte policies and / or poison pills to ensure protoc and plugin are used with supported version combinations first. Currently defacto with the built-in generators is that protoc + plugins are necessarily at the same version by default.

Keeping these private for now may help a bit with accidental mis-use in the interim, until we can get guardrails in place.

@bufdev bufdev Oct 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, making these private would pretty much defeat the goal of this PR - making these usable by others is the whole point :-)

Re: poison pills, do you just mean something like https://github.com/bufbuild/buf/blob/d500877026294fa52819fb20b98101d2c2c70fe3/private/gen/proto/go/buf/alpha/image/v1/image.pb.go#L33 or do you mean something more extensive? If this, we're happy to do this in this PR. If something more extensive, I'd question the need or desire - the rest of the Protobuf plugin ecosystem functions just fine without these type of block FWIW, and I think that's appropriate.

@zhangskz zhangskz Nov 12, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I was referring to some sort of version check enforcing only compatible versions are used!

Discussed with the team and it should be ok to accept these as public targets. Note though that we don't have guarantees for these in our support matrix yet for how these targets would be expected to behave yet esp when versions are mixed, so I do err on preffering some guardrails here (but followup should be fine for that).

@bufdev bufdev Nov 12, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK great to hear. Other than the failing tests below (which I think are unrelated, I'll merge the latest from main) is there anything else you'd like us to do in this PR?

deps = [
":cpp",
"//src/google/protobuf/compiler:plugin",
Expand Down
0 src/google/protobuf/compiler/cpp/main.cc → ...ogle/protobuf/compiler/cpp/plugin_main.cc
View file
Open in desktop
File renamed without changes.
10 changes: 10 additions & 0 deletions src/google/protobuf/compiler/csharp/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
load("@rules_pkg//pkg:mappings.bzl", "pkg_files", "strip_prefix")
load("//build_defs:cpp_opts.bzl", "COPTS")

cc_binary(
name = "protoc-gen-csharp",
srcs = ["plugin_main.cc"],
visibility = ["//visibility:public"],
deps = [
":csharp",
"//src/google/protobuf/compiler:plugin",
],
)

cc_library(
name = "names",
srcs = ["names.cc"],
Expand Down
14 changes: 14 additions & 0 deletions src/google/protobuf/compiler/csharp/plugin_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Protocol Buffers - Google's data interchange format

@zhangskz zhangskz Oct 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename these to plugin_main.cc instead of main.cc for consistency?

Looks like we use main.cc for c++ and rust today, and plugin_main.cc for java and python. I think plugin_main.cc is better here, and we should rename c++ and rust to follow that convention as well.

@bufdev bufdev Oct 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

// Copyright 2008 Google Inc. All rights reserved.
//
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file or at
// https://developers.google.com/open-source/licenses/bsd

#include "google/protobuf/compiler/csharp/csharp_generator.h"
#include "google/protobuf/compiler/plugin.h"

int main(int argc, char *argv[]) {
google::protobuf::compiler::csharp::Generator generator;
return google::protobuf::compiler::PluginMain(argc, argv, &generator);
}
10 changes: 10 additions & 0 deletions src/google/protobuf/compiler/java/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,16 @@ package(
],
)

cc_binary(
name = "protoc-gen-java",
srcs = ["plugin_main.cc"],
visibility = ["//visibility:public"],
deps = [
":java",
"//src/google/protobuf/compiler:plugin",
],
)

cc_library(
name = "names",
hdrs = ["names.h"],
Expand Down
10 changes: 10 additions & 0 deletions src/google/protobuf/compiler/kotlin/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
load("@rules_cc//cc:cc_library.bzl", "cc_library")
load("//build_defs:cpp_opts.bzl", "COPTS")

cc_binary(
name = "protoc-gen-kotlin",
srcs = ["plugin_main.cc"],
visibility = ["//visibility:public"],
deps = [
":kotlin",
"//src/google/protobuf/compiler:plugin",
],
)

cc_library(
name = "generator_headers",
hdrs = ["generator.h"],
Expand Down
14 changes: 14 additions & 0 deletions src/google/protobuf/compiler/kotlin/plugin_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Protocol Buffers - Google's data interchange format
// Copyright 2008 Google Inc. All rights reserved.
//
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file or at
// https://developers.google.com/open-source/licenses/bsd

#include "google/protobuf/compiler/kotlin/generator.h"
#include "google/protobuf/compiler/plugin.h"

int main(int argc, char *argv[]) {
google::protobuf::compiler::kotlin::KotlinGenerator generator;
return google::protobuf::compiler::PluginMain(argc, argv, &generator);
}
10 changes: 10 additions & 0 deletions src/google/protobuf/compiler/objectivec/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
load("@rules_pkg//pkg:mappings.bzl", "pkg_files", "strip_prefix")
load("//build_defs:cpp_opts.bzl", "COPTS")

cc_binary(
name = "protoc-gen-objectivec",
srcs = ["plugin_main.cc"],
visibility = ["//visibility:public"],
deps = [
":objectivec",
"//src/google/protobuf/compiler:plugin",
],
)

cc_library(
name = "names",
hdrs = ["names.h"],
Expand Down
14 changes: 14 additions & 0 deletions src/google/protobuf/compiler/objectivec/plugin_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Protocol Buffers - Google's data interchange format
// Copyright 2008 Google Inc. All rights reserved.
//
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file or at
// https://developers.google.com/open-source/licenses/bsd

#include "google/protobuf/compiler/objectivec/generator.h"
#include "google/protobuf/compiler/plugin.h"

int main(int argc, char *argv[]) {
google::protobuf::compiler::objectivec::ObjectiveCGenerator generator;
return google::protobuf::compiler::PluginMain(argc, argv, &generator);
}
10 changes: 10 additions & 0 deletions src/google/protobuf/compiler/php/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,16 @@ load("@rules_cc//cc:defs.bzl", "cc_library")
load("@rules_pkg//pkg:mappings.bzl", "pkg_files", "strip_prefix")
load("//build_defs:cpp_opts.bzl", "COPTS")

cc_binary(
name = "protoc-gen-php",
srcs = ["plugin_main.cc"],
visibility = ["//visibility:public"],
deps = [
":php",
"//src/google/protobuf/compiler:plugin",
],
)

cc_library(
name = "names",
srcs = ["names.cc"],
Expand Down
14 changes: 14 additions & 0 deletions src/google/protobuf/compiler/php/plugin_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Protocol Buffers - Google's data interchange format
// Copyright 2008 Google Inc. All rights reserved.
//
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file or at
// https://developers.google.com/open-source/licenses/bsd

#include "google/protobuf/compiler/php/php_generator.h"
#include "google/protobuf/compiler/plugin.h"

int main(int argc, char *argv[]) {
google::protobuf::compiler::php::Generator generator;
return google::protobuf::compiler::PluginMain(argc, argv, &generator);
}
20 changes: 20 additions & 0 deletions src/google/protobuf/compiler/python/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,26 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
load("@rules_pkg//pkg:mappings.bzl", "pkg_files", "strip_prefix")
load("//build_defs:cpp_opts.bzl", "COPTS")

cc_binary(
name = "protoc-gen-python",
srcs = ["plugin_main.cc"],
visibility = ["//visibility:public"],
deps = [
":python",
"//src/google/protobuf/compiler:plugin",
],
)

cc_binary(
name = "protoc-gen-pyi",
srcs = ["pyi_plugin_main.cc"],
visibility = ["//visibility:public"],
deps = [
":python",
"//src/google/protobuf/compiler:plugin",
],
)

cc_library(
name = "generator_headers",
hdrs = [
Expand Down
14 changes: 14 additions & 0 deletions src/google/protobuf/compiler/python/pyi_plugin_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Protocol Buffers - Google's data interchange format
// Copyright 2008 Google Inc. All rights reserved.
//
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file or at
// https://developers.google.com/open-source/licenses/bsd

#include "google/protobuf/compiler/plugin.h"
#include "google/protobuf/compiler/python/pyi_generator.h"

int main(int argc, char *argv[]) {
google::protobuf::compiler::python::PyiGenerator generator;
return google::protobuf::compiler::PluginMain(argc, argv, &generator);
}
10 changes: 10 additions & 0 deletions src/google/protobuf/compiler/ruby/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
load("@rules_pkg//pkg:mappings.bzl", "pkg_files", "strip_prefix")
load("//build_defs:cpp_opts.bzl", "COPTS")

cc_binary(
name = "protoc-gen-ruby",
srcs = ["plugin_main.cc"],
visibility = ["//visibility:public"],
deps = [
":ruby",
"//src/google/protobuf/compiler:plugin",
],
)

cc_library(
name = "generator_headers",
hdrs = ["ruby_generator.h"],
Expand Down
14 changes: 14 additions & 0 deletions src/google/protobuf/compiler/ruby/plugin_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Protocol Buffers - Google's data interchange format
// Copyright 2008 Google Inc. All rights reserved.
//
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file or at
// https://developers.google.com/open-source/licenses/bsd

#include "google/protobuf/compiler/plugin.h"
#include "google/protobuf/compiler/ruby/ruby_generator.h"

int main(int argc, char *argv[]) {
google::protobuf::compiler::ruby::Generator generator;
return google::protobuf::compiler::PluginMain(argc, argv, &generator);
}
4 changes: 2 additions & 2 deletions src/google/protobuf/compiler/rust/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ load(

cc_binary(
name = "protoc-gen-rust",
srcs = ["main.cc"],
visibility = ["//rust:__pkg__"],
srcs = ["plugin_main.cc"],
visibility = ["//visibility:public"],
deps = [
":rust",
"//src/google/protobuf/compiler:plugin",
Expand Down
0 src/google/protobuf/compiler/rust/main.cc → ...gle/protobuf/compiler/rust/plugin_main.cc
View file
Open in desktop
File renamed without changes.
Loading