java: limit numeric string length before BigDecimal parsing (#26908)#27063
Merged
Conversation
## Summary `BigDecimal(String)` has O(N²) time complexity for N-digit strings on JDK versions before 18 ([JDK-8291514](https://bugs.openjdk.org/browse/JDK-8291514)). Five JSON parser methods — `parseInt32`, `parseInt64`, `parseUint32`, `parseUint64`, and `parseDouble` — pass user-controlled strings directly to `new BigDecimal()` without length validation. A single JSON numeric value with 1,000,000 digits takes ~13 seconds to parse on JDK 17. This can be used to DoS any service that parses protobuf JSON messages with numeric fields from untrusted input. ### Benchmark (JDK 17, x86-64 Linux) | Digits | BigDecimal construction time | |--------|-----| | 1,000 | 1.8 ms | | 10,000 | 6.3 ms | | 100,000 | 133 ms | | 1,000,000 | **13.1 seconds** | ### Fix Added a `parseBigDecimal()` helper that rejects strings longer than 1000 characters before constructing `BigDecimal`. This is generous — valid protobuf numeric values never exceed ~350 characters (Double.MAX_VALUE in non-scientific notation is ~309 digits). ### Affected JDK versions - JDK 8, 11, 17 (all current LTS releases): **Vulnerable** — no built-in string length limit in BigDecimal - JDK 18+: JDK itself limits BigDecimal string input to 1100 characters by default (JDK-8291514), but the protobuf-level check is still worthwhile as defense-in-depth ### Test Added `testParserRejectOverlyLongNumericStrings` covering all 5 affected field types. Closes #26908 COPYBARA_INTEGRATE_REVIEW=#26908 from MindflareX:fix/java-bigdecimal-length-check a461d0e PiperOrigin-RevId: 904988136
9374e7e to
25e7005
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
java: limit numeric string length before BigDecimal parsing (#26908)
Summary
BigDecimal(String)has O(N²) time complexity for N-digit strings on JDK versions before 18 (JDK-8291514). Five JSON parser methods —parseInt32,parseInt64,parseUint32,parseUint64, andparseDouble— pass user-controlled strings directly tonew BigDecimal()without length validation.A single JSON numeric value with 1,000,000 digits takes ~13 seconds to parse on JDK 17. This can be used to DoS any service that parses protobuf JSON messages with numeric fields from untrusted input.
Benchmark (JDK 17, x86-64 Linux)
Fix
Added a
parseBigDecimal()helper that rejects strings longer than 1000 characters before constructingBigDecimal. This is generous — valid protobuf numeric values never exceed ~350 characters (Double.MAX_VALUE in non-scientific notation is ~309 digits).Affected JDK versions
Test
Added
testParserRejectOverlyLongNumericStringscovering all 5 affected field types.Closes #26908
COPYBARA_INTEGRATE_REVIEW=#26908 from MindflareX:fix/java-bigdecimal-length-check a461d0e
FUTURE_COPYBARA_INTEGRATE_REVIEW=#26908 from MindflareX:fix/java-bigdecimal-length-check a461d0e