Skip to content

Configure extra compile args in setup.py #28264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mitchallain wants to merge 2 commits into from
Closed

Configure extra compile args in setup.py #28264

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18c735d
Configure extra compile args in setup.py
mitchallain Jun 29, 2026
6e118a6
Omit visibility flag on MSVC
mitchallain Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/dist/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,12 @@ def GetVersion():

current_dir = os.path.dirname(os.path.abspath(__file__))
extra_link_args = []
extra_compile_args = []

if sys.platform.startswith('win'):
extra_link_args = ['-static']
else:
extra_compile_args = ['-fvisibility=hidden']

# If at some point the fasttable decoder is ready for prime time, we could
# enable it here. But even then we'll need to disable it on platforms where
Expand Down Expand Up @@ -86,6 +89,7 @@ def GetVersion():
include_dirs=[current_dir, os.path.join(current_dir, 'utf8_range')],
language='c',
extra_link_args=extra_link_args,
extra_compile_args=extra_compile_args,
)
],
python_requires='>=3.10',
Expand Down
Loading