Form group with radio is causing all radio buttons having checked attribute

[therajumandapati]

We're using <x-form-group> with a couple of <x-form-radio> elements inside. When a value is selected and the form reloads due to validation errors, all radio elements have the checked='checked' attribute.

I think this is due to the fact that <x-form-radio> component is using a class which extends FormCheckbox and because of the presence of this line: https://github.com/protonemedia/laravel-form-components/blob/master/src/Components/FormCheckbox.php#L33

It could be fixed by changing FormRadio.php to the following:

<?php

namespace ProtoneMedia\LaravelFormComponents\Components;

class FormRadio extends Component
{
    use HandlesValidationErrors;
    use HandlesBoundValues;

    public string $name;
    public string $label;
    public $value;
    public bool $checked = false;

    /**
     * Create a new component instance.
     *
     * @return void
     */
    public function __construct(
        string $name,
        string $label = '',
        $value = 1,
        $bind = null,
        bool $default = false,
        bool $showErrors = true
    ) {
        $this->name       = $name;
        $this->label      = $label;
        $this->value      = $value;
        $this->showErrors = $showErrors;

        if (old($name) == $value) { <== CHANGE
            $this->checked = true;
        }

        if (!session()->hasOldInput() && $this->isNotWired()) {
            $boundValue = $this->getBoundValue($bind, $name);

            $this->checked = is_null($boundValue) ? $default : $boundValue == $value; <== CHANGE
        }
    }
}

[pascalbaljet]

Thans for reporting, I'll try to fix it this week.

[betaselect]

Thanks @therajumandapati, you saved me quite some time!

[pascalbaljet]

Could you both try this branch and confirm it has been fixed? Thanks!

composer require protonemedia/laravel-form-components:dev-radio-bugfix-20

[pascalbaljet]

@Inwave @therajumandapati any news on testing the bugfix?

[betaselect]

Will check now!

[betaselect]

Just tested it and it works on my end. Thanks @pascalbaljet

[pascalbaljet]

Thanks, I'll merge it soon!

[pascalbaljet]

Fixed in v2.1.2

[therajumandapati]

Thanks for the fast turn around @pascalbaljet