Set preceding/succeeding pathType to range scope #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved this PR from provectus/kafka-ui#3933
Yes, but I'm not sure if anyone was using this correctly to begin with. See explanation below.
What changes did you make? (Give an overview)
#3259 introduced the ability to set the prefixType, however the preceedingPaths and succeedingPaths reference a variable that is out of scope of the range.
In the range section,
.Values.ingress.pathType
refers to.Values.ingress.succeedingPaths[n].Values.ingress.pathType
which I don't think was the intention.This change switches it to
.pathType
, which refers to.Values.ingress.succeedingPaths[n].pathType
, similar topath
,serviceName
, andservicePort
variables.Before this change in order to get the pathType set you'd need to configure the preceding/succeeding path to:
After this change it would reference be set by:
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Set new schema value and verified helm deployment worked.
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
Meet my dog Lupin!