Skip to content

Add consumer search in Topic View #2538 #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

shubhwip
Copy link
Collaborator

@shubhwip shubhwip commented Dec 18, 2022

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@shubhwip shubhwip requested a review from a team as a code owner December 18, 2022 17:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Haarolean Haarolean linked an issue Dec 19, 2022 that may be closed by this pull request
@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature scope/frontend labels Mar 15, 2023
Copy link
Contributor

@Mgrdich Mgrdich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And one more general thing @Haarolean here the search will be done on FE side rather than the BE is that okay ?

@Haarolean
Copy link
Contributor

And one more general thing @Haarolean here the search will be done on FE side rather than the BE is that okay ?

we can accept having one on FE as a start

@Haarolean Haarolean requested a review from a team March 20, 2023 10:56
@Haarolean Haarolean assigned Haarolean and unassigned armenuikafka Mar 28, 2023
@Haarolean Haarolean requested review from Haarolean and removed request for a team March 28, 2023 15:20
@Haarolean
Copy link
Contributor

@shubhwip good to merge once the failing checks pass

@Haarolean
Copy link
Contributor

@shubhwip good to merge once the failing checks pass

@shubhwip this will require you to check all the checkboxes :)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Haarolean Haarolean merged commit 1bcdec4 into provectus:master Apr 4, 2023
@Haarolean
Copy link
Contributor

@shubhwip thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend type/enhancement En enhancement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search consumers by name within topic details
4 participants