-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add consumer search in Topic View #2538 #3089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1ed90e6
to
6987245
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And one more general thing @Haarolean here the search will be done on FE side rather than the BE is that okay ?
kafka-ui-react-app/src/components/Topics/Topic/ConsumerGroups/TopicConsumerGroups.tsx
Outdated
Show resolved
Hide resolved
we can accept having one on FE as a start |
@shubhwip good to merge once the failing checks pass |
Kudos, SonarCloud Quality Gate passed! |
@shubhwip thank you :) |
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)