Skip to content

Set sio2 module default variant to newest revision by default #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

uyjulian
Copy link
Member

@uyjulian uyjulian commented Jun 14, 2025

This PR:

Moves modules out of system folder to sio and input folders
Renames the -old variants to -1300
Renames the r variants to -2000
Adds a -2000 variant to mcman
Makes the -2000 variant default

@rickgaiser
Copy link
Member

PR #746 / commit fe8fcb1 causes black screen on OPL.

If you ask me, this line is wrong:

g_sio2man_data.m_sdk13x_totalflag &= ~g_sio2man_data.m_sdk13x_curflag;

But I don't see any of the lines of code from that commit changed in this PR.
How does this PR fix OPL? Does OPL now use a different module variant?

@uyjulian
Copy link
Member Author

uyjulian commented Jun 14, 2025

OPL uses a different module variant. The main issue I saw was there was no 2000 API module variant of mcman so I added that and made it the default to avoid mixing up API versions.

@fjtrujy
Copy link
Member

fjtrujy commented Jun 15, 2025

OPL uses a different module variant. The main issue I saw was there was no 2000 API module variant of mcman so I added that and made it the default to avoid mixing up API versions.

I'm not against merging this PR, but you just made it OPL to work by creating this 2000 API variant, and the 1300 variant still looks wrong.
So, could you first try to take a look at the @rickgaiser comment, as I think we are doing something wrong with the m_sdk13x_totalflag and m_sdk13x_curflag variables?
It should be quite fast for you, as they are used just in a couple of places. So once found, you can create a tiny PR for fixing OPL to boot.

Then once done with this, please could you attach some description to this PR, why it is being created, needs, and/or improvements? I'm already quite lost with too many IOP libraries and versions...

Thanks

uyjulian added 2 commits June 17, 2025 17:41
Use 2000 as default variant
Label variants based on version
Add mcman 1400 variant
@uyjulian uyjulian force-pushed the sio2_modules_defaultvariant branch from 0181cd7 to c3453d5 Compare June 17, 2025 22:41
@uyjulian
Copy link
Member Author

The description has been updated.

The issue is that 1300 and 1400 versions of sio2man have the same API major version despite changes in locking behavior to handle multitap support. This causes issues (e.g. hangs when waiting on locks) when mixing the module versions between these versions without a clear reason as to why it occurs.

The 2000 version has a higher major version, which always has a separate lock reset function, so this avoids the conflicting API as modules targeting older sio2man will now fail with a version mismatch error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants