Ability to toggle the power LED state #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates the firmware with additional support for unofficial commands (so we can easily distinguish the official and unofficial firmware and features in Prismatik and make them both compatible). The new firmware version is (4-7).6+1. Official Prismatik releases still recognize the firmware as (4-7).6.
make LIGHTPACK_HW=x doesn't like being run multiple times in a row for different versions without cleaning the obj folder
| ReportData_u8[INDEX_FW_VER_MAJOR] = VERSION_OF_FIRMWARE_MAJOR; | ||
| ReportData_u8[INDEX_FW_VER_MINOR] = VERSION_OF_FIRMWARE_MINOR; | ||
| ReportData_u8[INDEX_FW_VER_UNOFFICIAL] = VERSION_OF_FIRMWARE_UNOFFICIAL; | ||
| return true; |
Owner
There was a problem hiding this comment.
I can't test this - all bytes in ReportData_u8 are zero unless set here?
There was a problem hiding this comment.
Yes, before this function is called the whole array is set to zero.
Also, the array is 64 bytes long, so there can't be a buffer overrun.
Owner
|
hey @Archomeda I'd really like to merge this, can you help me? |
Owner
|
@psieg-jenkins test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After posting this message on reddit, I thought "why not make this happen?". And so therefore this PR. I wanted to do this a long time ago, but I went on to do other things in the mean time.
Basically, this PR adds a checkbox in the device tab where you can disable the power LED state if you don't want that blue LED messing with the lights on your wall. It's a more complicated version than what's already done previously by other people (just calling
CLR(USBLED)in the firmware explicitly when it's loading). Myself, I just didn't want to fully disable it in the firmware, but make it toggleable instead.In order to support this feature, I had to modify the firmware a bit. Right now, it supports this feature by adding a separate version number that's only read by this version of Prismatik. In case the custom firmware is used in combination with the official Prismatik, it will just act like the official firmware. In case it's the other way around, the unofficial Prismatik will just ignore the additional features from the custom firmware as they don't exist in the official firmware. You can extend this by adding more commands if needed.
I've also compiled the new firmwares and committed them (a better solution is to have it built automatically and have it uploaded in the releases, but that's your call). The new version is x.6+1, where x is the hardware version. Official versions of Prismatik still recognize the firmware as x.6.