Skip to content

Add a setting for dithering, default false. #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2020
Merged

Add a setting for dithering, default false. #404

merged 2 commits into from
Nov 1, 2020

Conversation

@psieg
Copy link
Owner

@psieg psieg commented Oct 31, 2020

Fixes #398 by disabling dithering by default. The option exists in device settings now.

@zomfg
Copy link

zomfg commented Oct 31, 2020

maybe you are not done, but I tested and

  • when I start with dithering unchecked it flickers, and I have to check/uncheck every time to disable it
  • when started enabled it works as expected

@psieg
Copy link
Owner Author

psieg commented Nov 1, 2020

Right, I forgot the device initialization code. Thanks for testing!

@psieg psieg merged commit 419e50a into master Nov 1, 2020
@psieg psieg deleted the dithering_setting branch November 1, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flickering darker areas

3 participants

@psieg @zomfg