Intermittent system test error on `.alert-success`

[jywarren]

We've had intermittent system test errors before, and it sometimes boils down to timing errors or order of execution errors. See #9662 #9247

We're now seeing this one:

ERROR PostTest#test_awarding_barnstar_functions_correctly (196.06s)
Minitest::UnexpectedError:         Capybara::ExpectationNotMet: expected to find css "div.alert-success" but there were no matches
            test/system/post_test.rb:253:in `block in <class:PostTest>'

It's on line 253 of post_test.rb:

plots2/test/system/post_test.rb

Lines 243 to 256 in d35d935

	test "awarding barnstar functions correctly" do
	note = nodes(:one)
	visit note.path
	find("span[data-original-title='Tools']").click()
	find("input[value='Give']").click()
	# Wait for the alert to be shown
	wait_for_ajax
	page.assert_selector("div.alert-success", text: "You awarded the basic barnstar to #{note.author.name}")
	page.assert_selector("p", text: "#{note.author.name} was awarded the Basic Barnstar by palpatine for their work in this research note.")
	page.assert_selector(".comment-body p", text: "@palpatine awards a barnstar to #{note.author.name} for their awesome contribution!")
	end

Is this a standard way to wait? Why are we using page.assert_selector instead of just assert_selector?

Also, i think possibly this alert disappears after a few seconds. Could it be disappearing before we check for it?

[jywarren]

Yeah, they disappear after 7 seconds:

plots2/app/views/layouts/_alerts.html.erb

Line 34 in d35d935

setTimeout("$('.alerts-container .alert-success').fadeOut('slow')", 7000)

[jywarren]

We could try wrapping the timeout in a conditional for Rails.env == "test"...

[jywarren]

Unfortunately #10167 didn't completely solve it. It still happens sometimes! But rarely.

[jywarren]

Trying a fix here by just not looking for the item which is fading out: #10454 (comment)

[jywarren]

Also noting it's a full page refresh, not AJAX, so that might have contributed to the timing difficulties...?