Inconsistency in availability of "delete" button visible to author of note

[ebarry]

This bug is going to be hard to reproduce because I've just banned the author in order to meet their request of removing their content, hopefully temporarily.

Please describe the problem

What happened just before the problem occurred? Or what problem could this idea solve?

This user: https://publiclab.org/notes/author/jrmc502 wishes to delete their notes.

What did you expect to see that you didn't?

Of their two notes, this note shows the "delete" button: https://publiclab.org/notes/jrmc502/10-07-2020/towards-ai-assisted-water-testing-instructions

This post does not show the delete button: https://publiclab.org/notes/jrmc502/10-07-2020/towards-ai-assisted-water-testing

What's your PublicLab.org username?

This can help us diagnose the issue:

liz

[bhamster07]

Following up on a conversation with @jywarren about this issue, sharing full page screenshots that seem related to this: inconsistencies in sidebar menu options when viewing research notes authored by other users, from a non-admin/non-mod account. These screenshots are two different research notes from one author.

[anirudhprabhakaran3]

Is this happening for all authors? Or like some specific authors have some inconsistency?

[wajeehamushtaq]

@ebarry Can you please assign this issue to me so I can start working on it?

[ebarry]

I'll leave that to @TildaDares or @Tlazypanda to advise!

[TildaDares]

I think this issue is related to the one in #9543. The first note @bhamster screenshotted has no comment replies and the second one does.

The conditionals in app/views/notes/_comment.html.erb are assigning instead of comparing which means the current_user.id becomes equal to the replied_comment's id and if the replied_comment was made by the author or someone who can moderate, then the current_user has all of the author's/moderator's privileges on that note. @Goodiec all you need to do is add the two missing equals sign. It should be == not =.

plots2/app/views/notes/_comment.html.erb

Lines 174 to 175 in 7c49c77

	<% elsif current_user && current_user.id = replied_comment.author.id %>
	<% if replied_comment.status == 1 || (replied_comment.status == 4 && replied_comment.uid = current_user.id) %>

I'm not sure if this will solve the issue raised by @ebarry because I haven't been able to reproduce that bug.

[wajeehamushtaq]

@TildaDares Can I work on it?

[jywarren]

Hi @wajeehamushtaq I believe @Goodiec is working on this! @TildaDares that's an AMAZING catch there. I believe it's already fixed now in #10311 and so this should resolve once it publishes to the live site. Maybe later today!

[jywarren]

That makes so much sense. @bhamster07's user id was getting overwritten (temporarily, it wasn't saved) during current_user.id = replied_comment.author.id since it was assigning and not comparing. So yes, this should be resolved now! Thanks SO MUCH @TildaDares and @Goodiec, that's a fantastic fix!

[bhamster07]

🔍 Super sleuthing @TildaDares and @Goodiec, thank you!!

[ebarry]

Extra cool fix, thank you!