Ability to set timeframe for /tag/____ pages

[jywarren]

We have these great pages to show activity on a topic:

https://publiclab.org/tag/data-logging

However, sometimes we want to be able to see this for a given time period, to understand community growth in that timeframe, kind of like on GitHub Pulse:

https://github.com/publiclab/plots2/pulse/monthly vs.

https://github.com/publiclab/plots2/pulse/weekly

That looks like this (so we may need to set an interface, but for now let's just focus on the pages)

We have these great stats pages where you can set a range: https://publiclab.org/stats/range/10-05-2015/10-05-2016/

The code for that (for example) is:

plots2/app/controllers/stats_controller.rb

Lines 11 to 32 in efc315d

	def range
	@start = params[:start] ? Time.parse(params[:start]) : Time.now - 1.month
	@end = params[:end] ? Time.parse(params[:end]) : Time.now
	@notes = Node.select(%i(created type status))
	.where(type: 'note', status: 1, created: @start.to_i..@end.to_i)
	.count(:all)
	@wikis = Revision.select(:timestamp)
	.where(timestamp: @start.to_i..@end.to_i)
	.count - @notes # because notes each have one revision
	@people = User.where(created_at: @start..@end)
	.joins('INNER JOIN users ON users.uid = rusers.id')
	.where('users.status = 1')
	.count
	@answers = Answer.where(created_at: @start..@end)
	.count
	@comments = Comment.select(:timestamp)
	.where(timestamp: @start.to_i..@end.to_i)
	.count
	@questions = Node.questions.where(status: 1, created: @start.to_i..@end.to_i)
	.count
	@contributors = User.contributor_count_for(@start,@end)
	end

Next steps

This could be solved in a few steps, and the first might be to create a new Tag controller action like:

• https://publiclab.org/tag/data-logging?start=16-03-2016&end=14-04-2017 (Add time ranges in tag_controller#show #2618 by @rishabhptr)
• add weekly and monthly buttons like on GitHub Pulse to show the past week or month
• make graphs on tag pages Improved graphs on contributors/tags pages #2619 clickable to go to corresponding timeframe
• add some kind of date selector?

[rishabhptr]

@jywarren Can I try this?

[jywarren]

Please do! This would be great and @ebarry would like it too.

…

On Wed, Mar 7, 2018 at 10:47 AM, Rishabh Singh ***@***.***> wrote: @jywarren <https://github.com/jywarren> Can I try this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2439 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJzxzDtNLRE8pZ86DIQWcXGdRSq1Wks5tcAEagaJpZM4Sgqyl> .

[ebarry]

This will assist with metrics and evaluation, thank you!

[jywarren]

Hi @rishabhptr how is this coming? Thanks!

[rishabhptr]

Hey, I will make a pr with initial implementation for time ranges in a day or two for you to review. Thanks!

[rishabhptr]

Hey, as mentioned in the issue we need to create a new action for this instead of using optional parameters for dates in the original show action for tag. So what would be the response for the example request, the show page which resources filtered within the range or any new page with more descriptive information just like the stats page. Thanks 😄

[jywarren]

I think we can re-use the show template but add a line that displays the date range specified. Make sense? Thank you! This is exciting!

[jywarren]

And I wonder if we can add an optional filter to the ActiveRecord queries in the same action, rather than making a new action? We could add it after this line, and the matching one from the wildcard section above it:

plots2/app/controllers/tag_controller.rb

Line 96 in 2f35d87

.where('term_data.name = ? OR term_data.parent = ?', params[:id], params[:id])

We'd want to limit range based on, i guess, node creation date?

[rishabhptr]

Yes, that was exactly my thought, instead of new action we can use the same action with optional start and end parameters. Already the show method is quite detailed and good in finding different nodes for a tag and so it would avoid redundancy of the code and layout.
So I think I can go ahead with changes in the controller and then we can add the interface from which user can select and view data for a specific date range. Thanks for the help clarifying the issue! 😄

[jywarren]

super, that sounds great!

…

On Thu, Apr 12, 2018 at 10:08 AM, Rishabh Singh ***@***.***> wrote: Yes, that was exactly my thought, instead of new action we can use the same action with optional start and end parameters. Already the show method is quite detailed and good in finding different nodes for a tag and so it would avoid redundancy of the code and layout. So I think I can go ahead with changes in the controller and then we can add the interface from which user can select and view data for a specific date range. Thanks for the help clarifying the issue! 😄 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2439 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJy-zgug_xCuSRQoU6caM9O7UISHAks5tn23_gaJpZM4Sgqyl> .