Skip to content

Multi-Arch Releases #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025
Merged

Multi-Arch Releases #210

merged 3 commits into from
May 21, 2025

Conversation

Xeratec
Copy link
Member

@Xeratec Xeratec commented May 20, 2025

This PR adds support for building multi-arch releases. See https://github.com/Xeratec/bender/releases/tag/v0.28.3-rc1 for an example.

Added

  • New release_arm64 build stage

Changes

  • Renamed release stage to release_amd64

Fixed

  • Fixed ENV warning in Dockerfile

Note

  • During the build, the release files are placed in target/<architecture>/<platform> (e.g. target/arm64/ubuntu22.04)
  • To keep the release names compatible with earlier releases, amd64 is replaced with x86_64

@Xeratec Xeratec self-assigned this May 20, 2025
@Xeratec Xeratec added the enhancement New feature or request label May 20, 2025
@Xeratec Xeratec requested a review from micprog May 20, 2025 11:21
Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this extension! I have a few comments in the review. Also, please check if the names chosen work with the download script here:

curl --proto '=https' --tlsv1.2 https://pulp-platform.github.io/bender/init -sSf | sh

source: https://github.com/pulp-platform/bender/blob/website/init
If the script doesn't support arm64/aarch64 yet, extending it would be great!

Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@micprog micprog merged commit 768c426 into pulp-platform:master May 21, 2025
6 checks passed
@Xeratec Xeratec deleted the pr/multi-arch branch May 21, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants