Feature: add collective operation to snitch #250
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lura518
force-pushed
the
feature/narrow_reduction
branch
from
f4d5be4 to
fa1a967
Compare
Lura518
changed the title
|
TODO:
|
Lura518
force-pushed
the
feature/narrow_reduction
branch
from
fa1a967 to
93cb306
Compare
Lore0599
reviewed
Jul 3, 2025
Lura518
force-pushed
the
feature/narrow_reduction
branch
from
5c564e6 to
87ac36f
Compare
|
@Lura518 can you rebase on the latest |
Lura518
force-pushed
the
feature/narrow_reduction
branch
from
87ac36f to
5a7f22a
Compare
colluca
reviewed
Jul 4, 2025
There was a problem hiding this comment.
Thanks for the contribution!
I have quite some minor comments, regarding primarily the style guide and good practices. Let's address these, I can also take these over if you want.
Then let's have a call to discuss Lorenzo's comment on the XBAR port ordering. Perhaps we can also clean up the XBAR instantiations, if we make axi_mcast_xbar a proper superset of axi_xbar. I would have time to work on this next week, would be good to merge it in the same PR.
Lura518
force-pushed
the
feature/narrow_reduction
branch
from
5a7f22a to
4825c62
Compare
added 6 commits
July 9, 2025 14:08
* Extend snitch by adding CSR register for the user field * All collective operation will be forwarded to the (default-) SoC Port for further processing. Even if the crossbar is defined as mcast it is currently not being used as such. The problem are reduction operation as the crossbar does not support such operation and therefor all collectiv ops are forwarded to the SoC port (to be processed in the router there) * Bump bender dependencies (Cherry-Picked from 6402d71 of Lorenzos Fork)
* New configuration for the narrow reduction * Rename existing configuration options * Integrate multicast/reduction into the global barrier functions (Cherry-Picked from c9ed65c of Lorenzos Fork)
* Extend the axi xbar to offload collectiv operation to the SoC * Add new iDMA Opscode (Cherry-Picked from 0226903 of Lorenzos Fork)
* Extend the dma driver to support collectiv operation by setting the user field in the axi transmission (Cherry-Picked from 3af3efa of Lorenzos Fork)
Lura518
force-pushed
the
feature/narrow_reduction
branch
from
4825c62 to
a7bc2ec
Compare
colluca
reviewed
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds collective operation to the snitch cluster.
On the narrow interface we add a seperate CSR register which allows to set the user field of the narrow axi transmission.
The reduction/multicast operation is encoded in the axi user field of the narrow transmission and is executed outside of the cluster.
On the wide interface an special opcode for the iDMA was added. This opscode allows to set the user field in the iDMA directly.