-
Notifications
You must be signed in to change notification settings - Fork 132
Remove createrepo_c build docs #1230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bmbouter You can't remove everything, because the user still needs to install the build dependencies. The sdist we're uploading has to be compiled (transparently, on installation) so all of the build deps need to be there. |
|
|
||
| sudo apt install -y gcc make cmake libbz2-dev libexpat1-dev libmagic-dev libglib2.0-dev libcurl4-openssl-dev libxml2-dev libpython3-dev librpm-dev libssl-dev libsqlite3-dev liblzma-dev zlib1g-dev | ||
|
|
||
| Once the build deps are installed, you can simply install the ``createrepo_c`` package. It is not yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can, however, remove everything from here on down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also update Travis to remove the step where it downloads and installs from FedoraPeople.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it needs to be added as a dependency to setup.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that's right; let me fix this.
It's because it's an sdist and not a pre-compiled binary?
Are we doing local compilation because the pre-compiled one can't be compiled on the too-old Python environment?
What was the name of that Python build environment again so I can learn more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these changes are fixed in next push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency is now available on PyPI. https://pulp.plan.io/issues/4217 closes pulp#4217
4c91c40 to
0eb40f6
Compare
This dependency is now available on PyPI.
https://pulp.plan.io/issues/4217
closes #4217