Skip to content

Conversation

@bmbouter
Copy link
Member

This dependency is now available on PyPI.

https://pulp.plan.io/issues/4217
closes #4217

@dralley
Copy link
Contributor

dralley commented Nov 30, 2018

@bmbouter You can't remove everything, because the user still needs to install the build dependencies. The sdist we're uploading has to be compiled (transparently, on installation) so all of the build deps need to be there.


sudo apt install -y gcc make cmake libbz2-dev libexpat1-dev libmagic-dev libglib2.0-dev libcurl4-openssl-dev libxml2-dev libpython3-dev librpm-dev libssl-dev libsqlite3-dev liblzma-dev zlib1g-dev

Once the build deps are installed, you can simply install the ``createrepo_c`` package. It is not yet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can, however, remove everything from here on down.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update Travis to remove the step where it downloads and installs from FedoraPeople.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it needs to be added as a dependency to setup.py

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's right; let me fix this.

It's because it's an sdist and not a pre-compiled binary?
Are we doing local compilation because the pre-compiled one can't be compiled on the too-old Python environment?
What was the name of that Python build environment again so I can learn more?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes are fixed in next push.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is now available on PyPI.

https://pulp.plan.io/issues/4217
closes pulp#4217
@bmbouter bmbouter force-pushed the remote-createrepo-c-docs branch from 4c91c40 to 0eb40f6 Compare November 30, 2018 16:03
@dralley dralley merged commit c880bd1 into pulp:master Nov 30, 2018
@bmbouter bmbouter deleted the remote-createrepo-c-docs branch November 30, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants