Skip to content

Remove createrepo_c build docs #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dralley merged 1 commit into from
Nov 30, 2018
Merged

Remove createrepo_c build docs #1230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .travis/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ pushd pulp/plugin/ && pip install -e . && popd
### Install createrepo_c build deps ###
sudo apt-get update -y
sudo apt-get install -y gcc libbz2-dev cmake libexpat1-dev libmagic-dev libglib2.0-dev libcurl4-openssl-dev libxml2-dev libpython3-dev librpm-dev libssl-dev libsqlite3-dev liblzma-dev zlib1g-dev

pip install scikit-build
pip install https://repos.fedorapeople.org/pulp/pulp/python-packages/createrepo_c-0.11.1.tar.gz
#######################################

cd pulp_rpm
Expand Down
8 changes: 0 additions & 8 deletions docs/installation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,6 @@ If you are on Ubuntu or Debian, install the build dependencies with this command

sudo apt install -y gcc make cmake libbz2-dev libexpat1-dev libmagic-dev libglib2.0-dev libcurl4-openssl-dev libxml2-dev libpython3-dev librpm-dev libssl-dev libsqlite3-dev liblzma-dev zlib1g-dev

Once the build deps are installed, you can simply install the ``createrepo_c`` package. It is not yet
Copy link
Contributor

@dralley dralley Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can, however, remove everything from here on down.

Copy link
Contributor

@dralley dralley Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update Travis to remove the step where it downloads and installs from FedoraPeople.

Copy link
Contributor

@dralley dralley Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it needs to be added as a dependency to setup.py

Copy link
Member Author

@bmbouter bmbouter Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's right; let me fix this.

It's because it's an sdist and not a pre-compiled binary?
Are we doing local compilation because the pre-compiled one can't be compiled on the too-old Python environment?
What was the name of that Python build environment again so I can learn more?

Copy link
Member Author

@bmbouter bmbouter Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes are fixed in next push.

Copy link
Contributor

@dralley dralley Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See "re: #2"

rpm-software-management/createrepo_c#103 (comment)

available on PyPI, so for the time being we have hosted it ourselves:

.. code-block:: bash

pip install scikit-build
pip install https://repos.fedorapeople.org/pulp/pulp/python-packages/createrepo_c-0.11.1.tar.gz

Install ``pulp_rpm`` from source
********************************

Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from setuptools import setup, find_packages

requirements = [
'createrepo_c',
'pulpcore-plugin==0.1.0b13',
]

Expand Down