Add restart option pulpcore-worker #4685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
approved these changes
Nov 8, 2023
[noissue]
mdellweg
force-pushed
the
worker_reload
branch
from
4bee4b5 to
826c7f5
Compare
ipanova
reviewed
Nov 8, 2023
| @@ -0,0 +1 @@ | |||
| Added a ``--restart`` option to pulpcore worker. This requires "hupper" to be installed. | |||
Member
There was a problem hiding this comment.
what is this new way of adding a record to the changelog? there is no issue filed but you have pulpcore-worker-restart.features?
Contributor
There was a problem hiding this comment.
The + allows you to create an "orphan" changelog entry (or an entry without an issue).
Member
Author
There was a problem hiding this comment.
https://towncrier.readthedocs.io/en/stable/tutorial.html#creating-news-fragments
It's an orphan newsfragment.
Contributor
|
Is this purely a development feature or is it meant for end users? |
Member
Author
Development. Restarting in Production should be handled by e.g. the operator. |
ipanova
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]