(BOLT-1589) Support installing any git-based module#3115
Merged
Conversation
beechtom
force-pushed
the
1589/git-modules
branch
2 times, most recently
from
e690e74 to
269235d
Compare
Contributor
|
Not calculating a SHA means the Puppetfile no longer refers to a specific version of the module, correct? In the case where the ref is a branch, that is. |
Contributor
Author
|
@nicklewis Correct. I can add that back in, just a bit more work to get it working for GitLab & cloned sources. |
beechtom
force-pushed
the
1589/git-modules
branch
2 times, most recently
from
f8fd164 to
8b5c9b6
Compare
beechtom
force-pushed
the
1589/git-modules
branch
2 times, most recently
from
e3e95cb to
efdd65b
Compare
beechtom
commented
Jun 27, 2022
Contributor
Author
|
Blocked by glennsarti/puppetfile-resolver#38 |
donoghuc
approved these changes
Jun 29, 2022
donoghuc
left a comment
donoghuc
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the "in person" walkthrough on this. Looks good, and we have some thoughts for improving this moving forward.
This updates Bolt to support installing git-based modules from any source. Now, Bolt will attempt to download metadata directly from GitHub or GitLab for public repositories and fall back to cloning the git repo's metadata if that fails. This also updates the spec resolver to no longer calculate a SHA based on the ref provided in project configuration. Previously, Bolt would calculate a SHA and write it to the Puppetfile to pin the module to a specific commit when modules are installed. However, doing this is difficult and time-consuming with the move to supporting any git-based module. !feature * **Support installing any git-based module** ([puppetlabs#3109](puppetlabs#3109)) Bolt now supports installing any git-based module. Previously, Bolt only supported installing and resolving dependencies for modules hosted in a public GitHub repository. Now, Bolt will check both GitHub and GitLab before falling back to cloning a module's metadata using the `git` executable. This allows users to install modules from private repositories, or from locations other than GitHub.
This updates documentation for installing git modules to no longer say only public GitHub repositories are supported.
This fixes a bug where the proxy configured in `module-install.proxy` was not being set when retrieving metadata for git-based modules. Previously, the proxy was only configured when resolving and installing modules. !bug * **Configure proxy when retrieving metadata for git-based modules** Bolt now configures a proxy when `module-install.proxy` is set and it retrieves metadata for git-based modules. Previously, Bolt was only configuring a proxy when it resolved and installed modules.
beechtom
force-pushed
the
1589/git-modules
branch
from
efdd65b to
e1c804d
Compare
donoghuc
reviewed
Jul 25, 2022
donoghuc
reviewed
Jul 25, 2022
donoghuc
reviewed
Jul 25, 2022
donoghuc
left a comment
donoghuc
left a comment
Contributor
There was a problem hiding this comment.
Couple of minor suggestions, but overall this looks good!
This updates the `GitSpec` class to resolve the SHA for a git module's ref.
beechtom
force-pushed
the
1589/git-modules
branch
from
e1c804d to
61fed70
Compare
Contributor
Author
|
@donoghuc Updated with suggestions. |
donoghuc
approved these changes
Jul 26, 2022
donoghuc
left a comment
donoghuc
left a comment
Contributor
There was a problem hiding this comment.
Looks great! How do we want to handle bumping the puppetfile resolver dep in the runtime? https://github.com/puppetlabs/puppet-runtime/blob/master/configs/components/rubygem-puppetfile-resolver.rb
I think it may be simplest to bump it in the runtime and then once that promotes merge this.
Contributor
Author
|
@donoghuc Here's the PR to bump puppetfile-resolver (and other gem components): puppetlabs/puppet-runtime#561 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates Bolt to support installing git-based modules from any
source. Now, Bolt will attempt to download metadata directly from GitHub
or GitLab for public repositories and fall back to cloning the git
repo's metadata if that fails.
This also updates the spec resolver to no longer calculate a SHA based
on the ref provided in project configuration. Previously, Bolt would
calculate a SHA and write it to the Puppetfile to pin the module to a
specific commit when modules are installed. However, doing this is
difficult and time-consuming with the move to supporting any git-based
module.
!feature
Support installing any git-based module
(#3109)
Bolt now supports installing any git-based module. Previously, Bolt
only supported installing and resolving dependencies for modules
hosted in a public GitHub repository. Now, Bolt will check both GitHub
and GitLab before falling back to cloning a module's metadata using
the
gitexecutable. This allows users to install modules fromprivate repositories, or from locations other than GitHub.
This fixes a bug where the proxy configured in
module-install.proxywas not being set when retrieving metadata for git-based modules.
Previously, the proxy was only configured when resolving and
installing modules.
!bug
Configure proxy when retrieving metadata for git-based modules
Bolt now configures a proxy when
module-install.proxyis set and itretrieves metadata for git-based modules. Previously, Bolt was only
configuring a proxy when it resolved and installed modules.