-
Notifications
You must be signed in to change notification settings - Fork 28
Onceover fixes #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onceover fixes #157
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ source 'https://rubygems.org' | |
gem 'puppet', '~> 8.10' | ||
gem 'onceover', '~> 3.22' | ||
gem 'ffi', '~> 1.17' | ||
gem 'hiera-eyaml', '~> 4.0' | ||
gem 'hiera-eyaml', '~> 4.3' | ||
gem 'json', '~> 2.12' | ||
gem 'nokogiri', '~> 1.18' | ||
gem 'onceover-codequality', '~> 0.13' | ||
|
@@ -25,3 +25,5 @@ gem 'rspec-puppet', '~> 5.0' | |
gem 'rubocop', '~> 1.75' | ||
gem 'unf_ext', '~> 0.0.9' | ||
gem 'yamllint', '~> 0.0.9' | ||
gem 'rexml' | ||
gem 'bigdecimal', '= 3.2.1' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a comment here about why this is pinned so precisely, so we can see it and know what to check to repro the issue if we want to see if things have been fixed upstream down the line? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, missed this. The various gem dependencies aren't currently met unless we add this specific gem at this version. We can revisit it as part of an overarching review of the structure. If we don't include it, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a good idea to at least pin the major version here, like we've done with the others:
~> 3.2