Skip to content

Onceover fixes #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

Onceover fixes #157

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0916289
Add powershell binaries, and a specific version of big decimal to fix…
albatrossflavour Jun 6, 2025
8f99cb1
Pin rexml to 3.x
albatrossflavour Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ RUN apt-get install -y apt-utils \
&& apt-get upgrade -y \
&& apt-get install -y --no-install-recommends curl libxml2-dev libxslt1-dev g++ gcc git gnupg2 make openssh-client ruby-dev wget zlib1g-dev libldap-2.4-2 libldap-common libssl-dev openssl cmake pkg-config \
&& wget https://apt.puppet.com/puppet-tools-release-bullseye.deb \
&& wget https://packages.microsoft.com/config/ubuntu/22.04/packages-microsoft-prod.deb \
&& dpkg -i packages-microsoft-prod.deb \
&& dpkg -i puppet-tools-release-bullseye.deb \
&& apt-get update -qq \
&& apt-get install -y --no-install-recommends pdk=3.4.0.1-1bullseye \
&& apt-get install -y --no-install-recommends pdk=3.4.0.1-1bullseye powershell \
&& apt-get autoremove -y \
&& rm -rf /var/lib/apt/lists/*

Expand Down
4 changes: 3 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ source 'https://rubygems.org'
gem 'puppet', '~> 8.10'
gem 'onceover', '~> 3.22'
gem 'ffi', '~> 1.17'
gem 'hiera-eyaml', '~> 4.0'
gem 'hiera-eyaml', '~> 4.3'
gem 'json', '~> 2.12'
gem 'nokogiri', '~> 1.18'
gem 'onceover-codequality', '~> 0.13'
Expand All @@ -25,3 +25,5 @@ gem 'rspec-puppet', '~> 5.0'
gem 'rubocop', '~> 1.75'
gem 'unf_ext', '~> 0.0.9'
gem 'yamllint', '~> 0.0.9'
gem 'rexml'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea to at least pin the major version here, like we've done with the others: ~> 3.2

gem 'bigdecimal', '= 3.2.1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here about why this is pinned so precisely, so we can see it and know what to check to repro the issue if we want to see if things have been fixed upstream down the line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed this.

The various gem dependencies aren't currently met unless we add this specific gem at this version. We can revisit it as part of an overarching review of the structure.

If we don't include it, onceover (especially with --parallel) fails hard.