Fix detection of insecure interpolations in unless parameter#47
Merged
Conversation
The rspec-collection_matchers documentation advise to require rspec-collection_matchers form `spec_helper.rb`. This fix: ``` Failure/Error: expect(problems).to have(1).problems NoMethodError: undefined method `have' for #<RSpec::ExampleGroups::CheckUnsafeInterpolations::WithFixDisabled::ExecWithUnsafeInterpolationInCommand "detects an unsafe exec command argument" (./spec/puppet-lint/plugins/check_unsafe_interpolations_spec.rb:20)> ```
We produce 2 errors in this example. We don't want to check that the first one is present twice: we want to check that each warning is present once.
These commands are supposed to be supported, but they are not tested, so add tests to demonstrate that they work as intended.
When using the `unless` parameter of an `exec` resource with unsafe string interpolation, the linter should warn about the issue. It happen that it currently doesn't because unless is also a keyword. Adjust the linter to cope with this.
This was referenced Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
unlessparameter of anexecresource with unsafe string interpolation, the linter should warn about the issue.It happen that it currently doesn't because unless is also a keyword.
Adjust the linter to cope with this.
Also include: