SimpleProvider name fixes #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmil
force-pushed
the
simple_provider_name_fixes
branch
from
a4f9041 to
9fcde2e
Compare
|
|
seanmil
force-pushed
the
simple_provider_name_fixes
branch
from
9fcde2e to
67fe3ce
Compare
Expand test coverage for current behavior to encompass scenarios where ':is' isn't passed and to show problems with how types using composite namevars are handled.
As of the prior commit the simple provider correctly matches not only for types with composite namevars, but also types with arbitrarily named single namevars. Also, update the comments at the top of the SimpleProvider class to remove the note about namevar having to be "name".
LukasAud
force-pushed
the
simple_provider_name_fixes
branch
from
67fe3ce to
bb649d1
Compare
|
@seanmil Apologies for the rebase, I need to make sure this worked on latest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SimpleProvider has some support for composite namevars, but it is incomplete and only works in scenarios where the :is value is supplied. This PR adds more comprehensive unit tests which cover scenarios where :is is not passed and fixes these issues. As a bonus, the SimpleProvider now works for types with any namevar (it no longer is required to be
namefor the single-valued case). Some additional code cleanups are included.