Fix instances method with simple_get_filter #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, after sleeping on this, I'm not sure that changing the behavior in the code to match the documentation is the right change. It could be a functionally breaking change for someone who wrote code based on the actual implementation and not the documented behavior. Instead maybe it makes sense to update the documentation. I put up a PR for the Puppet Specifications at puppetlabs/puppet-specifications#155 but the Puppet docs on the docs website would also need to be fixed. |
|
|
|
Closing and re-opening to re-kick testing. |
Per issue puppetlabs#303, the Puppet Specification for Resource API indicates that a provider get() method when simple_get_filter is enabled should return all instances when the second/names parameter is set to 'nil'. Currently, if a Resource API provider is implemented per specification and uses the simple_get_filter feature it will never return any resources for the `instances()` method, which prevents things such a resource purging from working.
LukasAud
force-pushed
the
fix_simple_get_filter_instantiation
branch
from
1f06330 to
ecefc34
Compare
|
@seanmil Apologies for the rebase, I need to make sure this worked on latest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #303, the Puppet Specification for Resource API indicates that a provider get() method when simple_get_filter is enabled should return all instances when the second/names parameter is set to 'nil'.
Currently, if a Resource API provider is implemented per specification and uses the simple_get_filter feature it will never return any resources for the
instances()method, which prevents things such a resource purging from working.