Skip to content

Fix acceptance tests #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Conversation

danielparks
Copy link
Contributor

Previously, acceptance tests were failing during the initial installation of fixtures:

Cloning into 'spec/fixtures/modules/puppet_agent'...
fatal: unable to connect to github.com:
github.com[0: 140.82.113.4]: errno=Connection timed out

This switches to using https URLs for the fixtures, which allows acceptance tests to proceed beyond that point.


I don’t normally use Docker, so it’s hard for me to tell what’s problem on my machine and what’s a problem with the acceptance testing setup. I’m getting errors while spinning up the CentOS container:

Failure connecting to localhost:52595:
{"target"=>"localhost:52595", "action"=>"command", "object"=>nil, "status"=>"failure", "value"=>{"_error"=>{"details"=>{}, "kind"=>"puppetlabs.tasks/connect-error", "msg"=>"Failed to connect to localhost:52595: pkeys are immutable on OpenSSL 3.0", "issue_code"=>"CONNECT_ERROR"}}}

Previously, acceptance tests were failing during the initial
installation of fixtures:

> Cloning into 'spec/fixtures/modules/puppet_agent'...
> fatal: unable to connect to github.com:
> github.com\[0: 140.82.113.4]: errno=Connection timed out

This switches to using `https` URLs for the fixtures, which allows
acceptance tests to proceed beyond that point.
@danielparks
Copy link
Contributor Author

Looks like those errors are on my end, since they succeed in Travis. I also took the opportunity to add the new (?) location of the Litmus inventory file to .gitignore.

@danielparks danielparks changed the title [WIP] Fix acceptance tests Fix acceptance tests Sep 25, 2022
@danielparks danielparks marked this pull request as ready for review September 25, 2022 07:53
@danielparks danielparks requested a review from a team as a code owner September 25, 2022 07:53
@chelnak
Copy link
Contributor

chelnak commented Sep 26, 2022

This fix is spot on. Thank you.

@chelnak chelnak merged commit 5fe07ba into puppetlabs:main Sep 26, 2022
@danielparks danielparks deleted the fix_acceptance_tests branch September 26, 2022 08:08
@chelnak chelnak self-assigned this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants