Skip to content

(CONT-812) Puppet 8 / Ruby 3 support #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 60 commits into from
Apr 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
92f0101
(CONT-812) Update dependencies
chelnak Apr 13, 2023
cc302b5
(CONT-812) Update test matrix setups
chelnak Apr 13, 2023
fa334f3
(CONT-812) Update acceptance test setup
chelnak Apr 13, 2023
5fa8277
(CONT-812) Update rubocop config
chelnak Apr 13, 2023
cb6d2dc
(CONT-812) Fix failing acceptance test
chelnak Apr 13, 2023
ce14c00
(CONT-812) Correct Layout/EmptyLineAfterGuardClause
chelnak Apr 17, 2023
e917077
(CONT-812) Correct Layout/HashAlignment
chelnak Apr 17, 2023
75c653f
(CONT-812) Correct Layout/LeadingCommentSpace
chelnak Apr 17, 2023
f23f0f1
(CONT-812) Correct Layout/LineContinuationSpacing
chelnak Apr 17, 2023
ede8656
(CONT-812) Correct Layout/LineEndStringConcatenationIndentation
chelnak Apr 17, 2023
4f731e7
(CONT-812) Correct Layout/SpaceAfterComma
chelnak Apr 17, 2023
2533c11
(CONT-812) Correct Layout/SpaceAroundMethodCallOperator
chelnak Apr 17, 2023
69e206e
(CONT-812) Correct Layout/SpaceInsideBlockBraces
chelnak Apr 17, 2023
d7f5e44
(CONT-812) Correct Lint/ErbNewArguments
chelnak Apr 17, 2023
10fd31e
(CONT-812) Correct Lint/RedundantSafeNavigation
chelnak Apr 17, 2023
99b7641
(CONT-812) Correct Performance/BindCall
chelnak Apr 17, 2023
3231e23
(CONT-812) Correct Performance/StringInclude
chelnak Apr 17, 2023
d4c582a
(CONT-812) Correct RSpec/BeEq
chelnak Apr 17, 2023
5ff9836
(CONT-812) Correct RSpec/EmptyLineAfterExampleGroup
chelnak Apr 17, 2023
2b122ee
(CONT-812) Correct RSpec/HookArgument
chelnak Apr 17, 2023
73787ec
(CONT-812) Correct RSpec/PredicateMatcher
chelnak Apr 17, 2023
c3c05b6
(CONT-812) Correct Style/AccessorGrouping
chelnak Apr 17, 2023
0af1419
(CONT-812) Correct Style/BlockDelimiters
chelnak Apr 17, 2023
b8bcb5f
(CONT-812) Correct Style/CaseLikeIf
chelnak Apr 17, 2023
e8d9d0c
(CONT-812) Correct Style/ClassEqualityComparison
chelnak Apr 17, 2023
7847a3e
(CONT-812) Correct Style/ExpandPathArguments
chelnak Apr 17, 2023
bea4f2f
(CONT-812) Correct Style/FileWrite
chelnak Apr 17, 2023
4971557
(CONT-812) Correct Style/FormatString
chelnak Apr 17, 2023
3c1610e
(CONT-812) Correct Style/FormatStringToken
chelnak Apr 17, 2023
13baac0
(CONT-812) Correct Style/FrozenStringLiteralComment
chelnak Apr 17, 2023
ddaf409
(CONT-812) Correct Style/GlobalStdStream
chelnak Apr 17, 2023
fdb4b3f
(CONT-812) Correct Style/HashConversion
chelnak Apr 17, 2023
7ed9383
(CONT-812) Correct Style/IfUnlessModifier
chelnak Apr 17, 2023
23d59e2
(CONT-812) Correct Style/IfWithBooleanLiteralBranches
chelnak Apr 17, 2023
e314ce4
(CONT-812) Correct Style/MultilineIfModifier
chelnak Apr 17, 2023
0ea6dee
(CONT-812) Correct Style/NumericPredicate
chelnak Apr 17, 2023
2e2c759
(CONT-812) Correct Style/OneLineConditional
chelnak Apr 17, 2023
ca99208
(CONT-812) Correct Style/RedundantArgument
chelnak Apr 17, 2023
ffe00f0
(CONT-812) Correct Style/RedundantFileExtensionInRequire
chelnak Apr 17, 2023
ddc7f43
(CONT-812) Correct Style/RedundantHeredocDelimiterQuotes
chelnak Apr 17, 2023
cadcf9d
(CONT-812) Correct Style/RedundantRegexpCharacterClass
chelnak Apr 17, 2023
c9fbbce
(CONT-812) Correct Style/RedundantRegexpEscape
chelnak Apr 17, 2023
0b4a28c
(CONT-812) Correct Style/RedundantStringEscape
chelnak Apr 17, 2023
35b9aed
(CONT-812) Correct Style/RegexpLiteral
chelnak Apr 17, 2023
4bdc06b
(CONT-812) Correct Style/RescueStandardError
chelnak Apr 17, 2023
45b0786
(CONT-812) Correct Style/SafeNavigation
chelnak Apr 17, 2023
c663b7b
(CONT-812) Correct Style/SlicingWithRange
chelnak Apr 17, 2023
530e86a
(CONT-812) Correct Style/StderrPuts
chelnak Apr 17, 2023
c9198ee
(CONT-812) Correct Style/StringConcatenation
chelnak Apr 17, 2023
bd9f5f9
(CONT-812) Correct Style/StringConcatenation
chelnak Apr 17, 2023
a5832b1
(CONT-812) Correct Style/SymbolProc
chelnak Apr 17, 2023
058f9e3
(CONT-812) Correct Style/TrailingCommaInArguments
chelnak Apr 17, 2023
2fb7cf4
(CONT-812) Correct Style/TrailingCommaInArrayLiteral
chelnak Apr 17, 2023
71cab16
(CONT-812) Correct Style/TrailingCommaInHashLiteral
chelnak Apr 17, 2023
5ff6902
(CONT-812) Correct Style/WordArray
chelnak Apr 17, 2023
1ee7abd
(CONT-812) Correct Style/StringConcatenation
chelnak Apr 17, 2023
a256607
(CONT-812) Fix spec failures
chelnak Apr 17, 2023
5b44c36
(CONT-812) Clean up redundant files
chelnak Apr 17, 2023
0e077a3
(CONT-812) Remove Puppet 5 check for plans
chelnak Apr 17, 2023
fc22265
(CONT-812) Ensure that @alias_of is mutable
chelnak Apr 17, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .fixtures.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ fixtures:
facts: 'https://github.com/puppetlabs/puppetlabs-facts.git'
provision: 'https://github.com/puppetlabs/provision.git'
puppet_agent: 'https://github.com/puppetlabs/puppetlabs-puppet_agent.git'
symlinks: []
symlinks:
test: "#{source_dir}/spec/fixtures/acceptance/modules/test"
43 changes: 36 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,24 +1,53 @@
name: "ci"

on:
schedule:
- cron: "0 0 * * *"
pull_request:
branches:
- "main"
workflow_dispatch:

jobs:

spec:
strategy:
fail-fast: false
matrix:
ruby_version:
- "2.7"
- "3.2"
include:
- ruby-version: '2.7'
puppet_gem_version: '~> 7.0'
- ruby_version: '3.2'
puppet_gem_version: 'https://github.com/puppetlabs/puppet' # puppet8'
runs_on:
- "ubuntu-latest"
- "windows-latest"
name: "spec (${{ matrix.runs_on }} ruby ${{ matrix.ruby_version }} | puppet ${{matrix.puppet_gem_version}})"
uses: "puppetlabs/cat-github-actions/.github/workflows/gem_ci.yml@main"
secrets: "inherit"
with:
ruby_version: ${{ matrix.ruby_version }}
puppet_gem_version: ${{ matrix.puppet_gem_version }}
runs_on: ${{ matrix.runs_on }}

acceptance:
needs: "spec"
strategy:
matrix:
puppet:
- "puppet6"
- "puppet7"
ruby_version:
- "2.7"
- "3.2"
include:
- ruby-version: '2.7'
puppet_gem_version: '~> 7.0'
- ruby_version: '3.2'
puppet_gem_version: 'https://github.com/puppetlabs/puppet' # puppet8'
runs_on:
- "ubuntu-latest"
- "windows-latest"
uses: "puppetlabs/cat-github-actions/.github/workflows/gem_acceptance.yml@main"
secrets: "inherit"
with:
puppet_version: ${{ matrix.puppet }}
ruby_version: ${{ matrix.ruby_version }}
puppet_version: ${{ matrix.puppet_gem_version }}
runs_on: ${{ matrix.runs_on }}
43 changes: 35 additions & 8 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
@@ -1,25 +1,52 @@
name: "nightly"

on:
pull_request:
branches:
- "main"
schedule:
- cron: "0 0 * * *"
workflow_dispatch:

jobs:

spec:
strategy:
fail-fast: false
matrix:
ruby_version:
- "2.7"
- "3.2"
include:
- ruby-version: '2.7'
puppet_gem_version: '~> 7.0'
- ruby_version: '3.2'
puppet_gem_version: 'https://github.com/puppetlabs/puppet' # puppet8'
runs_on:
- "ubuntu-latest"
- "windows-latest"
name: "spec (${{ matrix.runs_on }} ruby ${{ matrix.ruby_version }} | puppet ${{matrix.puppet_gem_version}})"
uses: "puppetlabs/cat-github-actions/.github/workflows/gem_ci.yml@main"
secrets: "inherit"
with:
ruby_version: ${{ matrix.ruby_version }}
puppet_gem_version: ${{ matrix.puppet_gem_version }}
runs_on: ${{ matrix.runs_on }}

acceptance:
needs: "spec"
strategy:
matrix:
puppet:
- "puppet6"
- "puppet7"
ruby_version:
- "2.7"
- "3.2"
include:
- ruby-version: '2.7'
puppet_gem_version: '~> 7.0'
- ruby_version: '3.2'
puppet_gem_version: 'https://github.com/puppetlabs/puppet' # puppet8'
runs_on:
- "ubuntu-latest"
- "windows-latest"
uses: "puppetlabs/cat-github-actions/.github/workflows/gem_acceptance.yml@main"
secrets: "inherit"
with:
puppet_version: ${{ matrix.puppet }}
ruby_version: ${{ matrix.ruby_version }}
puppet_version: ${{ matrix.puppet_gem_version }}
runs_on: ${{ matrix.runs_on }}
Loading