Skip to content

feat: use puppetcore by default in matrix_from_metadata #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented May 1, 2025

Summary

Updates matrix_from_metadata v2/v3 to use puppetcore by default

See example ci run https://github.com/puppetlabs/puppetlabs-peadm/actions/runs/14776268433/job/41485188480 (unsigned SLES 12 package has been raised with RE)

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 marked this pull request as ready for review May 1, 2025 13:41
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner May 1, 2025 13:41
Copy link
Contributor

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavindidrichsen gavindidrichsen merged commit a12e295 into main May 2, 2025
3 checks passed
@gavindidrichsen gavindidrichsen deleted the use_puppetcore_matrix_from_metadata branch May 2, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants