Skip to content

Automatically enable mod_http2 if needed #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2022
Merged

Automatically enable mod_http2 if needed #2337

merged 1 commit into from
Oct 25, 2022

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Oct 13, 2022

Following https://httpd.apache.org/docs/current/howto/http2.html the first step is to load the http2 module. By inspecting the protocols argument users can enable HTTP/2 via Hiera.

@ekohl
Automatically enable mod_http2 if needed
6fa784a 
Following https://httpd.apache.org/docs/current/howto/http2.html the
first step is to load the http2 module. By inspecting the protocols
argument users can enable HTTP/2 via Hiera.
@ekohl ekohl requested a review from a team as a code owner October 13, 2022 18:52
@puppet-community-rangefinder
Copy link

apache is a class

Breaking changes to this file WILL impact these 144 modules (exact match):
Breaking changes to this file MAY impact these 56 modules (near match):

apache::vhost is a type

Breaking changes to this file WILL impact these 128 modules (exact match):
Breaking changes to this file MAY impact these 36 modules (near match):

This module is declared in 174 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@ekohl ekohl requested review from chelnak and david22swan October 19, 2022 18:26
@ekohl
Copy link
Collaborator Author

ekohl commented Oct 24, 2022

@david22swan @chelnak it would help me a lot if this was reviewed and merged this week.

david22swan
david22swan approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit 88f611e into puppetlabs:main Oct 25, 2022
@ekohl ekohl deleted the auto-enable-http2 branch October 25, 2022 10:22
@ekohl ekohl mentioned this pull request Oct 26, 2022
Merged
@ekohl ekohl added the feature label Oct 28, 2022
@ekohl ekohl mentioned this pull request Apr 14, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

@chelnak chelnak Awaiting requested review from chelnak

Assignees
No one assigned
Labels
community feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekohl @david22swan @ia-content