(CAT-2548): Revert "Rubocop safe autocorrections"

.rubocop.yml

@@ -421,6 +421,8 @@ Style/HashAsLastArrayItem:
   Enabled: false
 Style/HashLikeCase:
   Enabled: false
+Style/HashSyntax:
+  Enabled: false
 Style/HashTransformKeys:
   Enabled: false
 Style/HashTransformValues:

lib/puppet/functions/inifile/create_ini_settings.rb

@@ -15,7 +15,7 @@ def default_impl(settings, defaults = {})
     resources = settings.keys.each_with_object({}) do |section, res|
       unless settings[section].is_a?(Hash)
         raise(Puppet::ParseError,
-              _('create_ini_settings(): Section %{section} must contain a Hash') % { section: })
+              _('create_ini_settings(): Section %{section} must contain a Hash') % { section: section })
       end
 
       path = defaults.merge(settings)['path']

lib/puppet/provider/ini_setting/ruby.rb

@@ -19,7 +19,7 @@ def self.instances
         resources.push(
           new(
             name: namevar(section_name, setting),
-            value:,
+            value: value,
             ensure: :present,
           ),
         )

lib/puppet/type/ini_setting.rb

@@ -60,7 +60,7 @@ def munge_boolean_md5(value)
   newparam(:path) do
     desc 'The ini file Puppet will ensure contains the specified setting.'
     validate do |value|
-      raise(Puppet::Error, _("File paths must be fully qualified, not '%{value}'") % { value: }) unless Puppet::Util.absolute_path?(value)
+      raise(Puppet::Error, _("File paths must be fully qualified, not '%{value}'") % { value: value }) unless Puppet::Util.absolute_path?(value)
     end
   end
 

lib/puppet/type/ini_subsetting.rb

@@ -52,7 +52,7 @@ def munge_boolean_md5(value)
   newparam(:path) do
     desc 'The ini file Puppet will ensure contains the specified setting.'
     validate do |value|
-      raise(Puppet::Error, _("File paths must be fully qualified, not '%{value}'") % { value: }) unless Puppet::Util.absolute_path?(value)
+      raise(Puppet::Error, _("File paths must be fully qualified, not '%{value}'") % { value: value }) unless Puppet::Util.absolute_path?(value)
     end
   end
   newparam(:show_diff) do

lib/puppet/util/ini_file.rb

@@ -68,9 +68,9 @@ def set_value(*args)
       end
 
       complete_setting = {
-        setting:,
-        separator:,
-        value:
+        setting: setting,
+        separator: separator,
+        value: value
       }
       add_section(Section.new(section_name, nil, nil, nil, nil)) unless @sections_hash.key?(section_name)
 
@@ -283,7 +283,7 @@ def find_commented_setting(section, setting)
 
       (section.start_line..section.end_line).each do |line_num|
         next unless (match = @commented_setting_regex.match(lines[line_num]))
-        return { match:, line_num: } if match[3] == setting
+        return { match: match, line_num: line_num } if match[3] == setting
       end
       nil
     end

spec/unit/puppet/provider/ini_setting/ruby_spec.rb

@@ -721,7 +721,7 @@ def self.file_path
       expected = orig_content
       { 'section' => { 'first' => 1 } }.each_pair do |section, settings|
         settings.each_pair do |setting, value|
-          resource = Puppet::Type::Ini_setting.new(common_params.merge(section:, setting:, value:))
+          resource = Puppet::Type::Ini_setting.new(common_params.merge(section: section, setting: setting, value: value))
           provider = described_class.new(resource)
           expect(provider.exists?).to be false
           # byebug

spec/unit/puppet/type/ini_setting_spec.rb

@@ -6,7 +6,7 @@
 
 describe ini_setting do
   describe 'path validation' do
-    subject(:ini_setting_path) { described_class.new(name: 'foo', path:) }
+    subject(:ini_setting_path) { described_class.new(name: 'foo', path: path) }
 
     context 'when on posix platforms' do
       before(:each) do

spec/unit/puppet/type/ini_subetting_spec.rb

@@ -6,7 +6,7 @@
 
 describe ini_subsetting do
   describe 'quote_char validation' do
-    subject(:ini_subsetting_test) { described_class.new(name: 'foo', path:, quote_char:) }
+    subject(:ini_subsetting_test) { described_class.new(name: 'foo', path: path, quote_char: quote_char) }
 
     context 'when on posix platforms' do
       let(:path) { '/absolute/path' }
@@ -17,7 +17,7 @@
   end
 
   describe 'path validation' do
-    subject(:ini_subsetting_test) { described_class.new(name: 'foo', path:) }
+    subject(:ini_subsetting_test) { described_class.new(name: 'foo', path: path) }
 
     context 'when on posix platforms' do
       before(:each) do